Skip to content

update vault mssql docs #2267

Open
sachin-chand01 wants to merge 5 commits intomainfrom
VAULT-43670-update-mssql-docs
Open

update vault mssql docs #2267
sachin-chand01 wants to merge 5 commits intomainfrom
VAULT-43670-update-mssql-docs

Conversation

@sachin-chand01
Copy link
Copy Markdown

PR Description

Summary

Updates the permissions for the MSSQL docs for this bug fix

MSSql Server database plugin throws "Logins other than the current user can only be seen by members of the sysadmin role." when using the default revocation statement.

Please go to the Preview tab and select the appropriate template:

Terraform

@sachin-chand01 sachin-chand01 requested a review from a team as a code owner April 17, 2026 10:18
@github-actions github-actions Bot added the Vault Content update for Vault product docs label Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Tue Apr 28 11:10:44 UTC 2026
Unified Docs API ✅ Ready (Inspect) Visit Preview Tue Apr 28 11:06:48 UTC 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

Broken Link Checker

This PR contains broken links, but won't be blocked. Use this report to improve content quality:

Quick Actions

  • Internal links (HashiCorp sites): Please fix these - they impact user experience
  • External links: Consider if these are essential or can be updated/removed
  • Temporary issues: External sites may recover - check again before merging

Need Help?


Internal Links

Full Github Actions output

External Links

Summary

Status Count
🔍 Total 15
✅ Successful 3
⏳ Timeouts 0
🔀 Redirected 3
👻 Excluded 9
❓ Unknown 0
🚫 Errors 0
⛔ Unsupported 0

Redirects per input

Redirects in content/vault/v1.19.x/content/docs/secrets/databases/mssql.mdx

Redirects in content/vault/v1.21.x/content/docs/secrets/databases/mssql.mdx

Redirects in content/vault/v2.x/content/docs/secrets/databases/mssql.mdx

Full Github Actions output

@schavis
Copy link
Copy Markdown
Contributor

schavis commented Apr 17, 2026

@sachin-chand01 Is this fix part of 2.0.0?

@schavis
Copy link
Copy Markdown
Contributor

schavis commented Apr 27, 2026

@sachin-chand01 Is the bug fix part of the May release? If so, please change the merge target to vault/202505 and make sure to add an entry to the 2.x release notes

@sachin-chand01
Copy link
Copy Markdown
Author

sachin-chand01 commented Apr 28, 2026

@sachin-chand01 Is the bug fix part of the May release? If so, please change the merge target to vault/202505 and make sure to add an entry to the 2.x release notes

@schavis No, this fix is not part of May release. It’s planned for the 2.1.0 release.

@schavis
Copy link
Copy Markdown
Contributor

schavis commented Apr 28, 2026

@schavis No, this fix is not part of May release. It’s planned for the 2.1.0 release.

So it's part of the October release? I didn't realize we needed a release branch for that already.

Let me create one and you can change the merge target. To clarify: the content repo doesn't work like the product repo. Merging something to main publishes those changes to the public docs immediately.

@sachin-chand01
Copy link
Copy Markdown
Author

So it's part of the October release? I didn't realize we needed a release branch for that already.

Let me create one and you can change the merge target. To clarify: the content repo doesn't work like the product repo. Merging something to main publishes those changes to the public docs immediately.

Got it, that makes sense! Thanks for catching that. I’ll switch the merge target once the release branch is ready.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the MSSQL database secrets engine documentation to reflect additional permissions required by the default revocation behavior and to clarify revocation behavior constraints.

Changes:

  • Add additional SQL Server permissions (VIEW ANY DEFINITION, VIEW SERVER STATE, VIEW DEFINITION) to the “minimum functionality” grant set.
  • Add a warning that the default revocation procedure’s metadata query is scoped to the database in connection_url, which can prevent cleanup when users are created in a different database.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
content/vault/v2.x/content/docs/secrets/databases/mssql.mdx Adds required grants and clarifies default revocation scoping behavior.
content/vault/v1.21.x/content/docs/secrets/databases/mssql.mdx Same as v2.x, but contains a duplicated-phrase typo in the newly added warning text.
content/vault/v1.19.x/content/docs/secrets/databases/mssql.mdx Adds required grants and clarifies default revocation scoping behavior.


~> **Be aware!** If no `revocation_statement` is supplied,
vault will execute the default revocation procedure.
This procedure utilizes a procedure utilizes a
Copy link

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a duplicated phrase in this sentence ("utilizes a procedure utilizes a"), which reads like a copy/paste error and makes the warning hard to understand. Please remove the duplicated words (e.g., keep a single "utilizes a" / "uses a").

Suggested change
This procedure utilizes a procedure utilizes a
This procedure uses a

Copilot uses AI. Check for mistakes.
@stuti-sr stuti-sr self-requested a review April 29, 2026 04:30
Copy link
Copy Markdown
Contributor

@stuti-sr stuti-sr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Vault Content update for Vault product docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants