update vault mssql docs #2267
Conversation
Vercel Previews Deployed
|
|
@sachin-chand01 Is this fix part of 2.0.0? |
|
@sachin-chand01 Is the bug fix part of the May release? If so, please change the merge target to |
@schavis No, this fix is not part of May release. It’s planned for the 2.1.0 release. |
So it's part of the October release? I didn't realize we needed a release branch for that already. Let me create one and you can change the merge target. To clarify: the content repo doesn't work like the product repo. Merging something to main publishes those changes to the public docs immediately. |
Got it, that makes sense! Thanks for catching that. I’ll switch the merge target once the release branch is ready. |
There was a problem hiding this comment.
Pull request overview
Updates the MSSQL database secrets engine documentation to reflect additional permissions required by the default revocation behavior and to clarify revocation behavior constraints.
Changes:
- Add additional SQL Server permissions (
VIEW ANY DEFINITION,VIEW SERVER STATE,VIEW DEFINITION) to the “minimum functionality” grant set. - Add a warning that the default revocation procedure’s metadata query is scoped to the database in
connection_url, which can prevent cleanup when users are created in a different database.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| content/vault/v2.x/content/docs/secrets/databases/mssql.mdx | Adds required grants and clarifies default revocation scoping behavior. |
| content/vault/v1.21.x/content/docs/secrets/databases/mssql.mdx | Same as v2.x, but contains a duplicated-phrase typo in the newly added warning text. |
| content/vault/v1.19.x/content/docs/secrets/databases/mssql.mdx | Adds required grants and clarifies default revocation scoping behavior. |
|
|
||
| ~> **Be aware!** If no `revocation_statement` is supplied, | ||
| vault will execute the default revocation procedure. | ||
| This procedure utilizes a procedure utilizes a |
There was a problem hiding this comment.
There is a duplicated phrase in this sentence ("utilizes a procedure utilizes a"), which reads like a copy/paste error and makes the warning hard to understand. Please remove the duplicated words (e.g., keep a single "utilizes a" / "uses a").
| This procedure utilizes a procedure utilizes a | |
| This procedure uses a |
PR Description
Summary
Updates the permissions for the MSSQL docs for this bug fix
Please go to the
Previewtab and select the appropriate template:Terraform