-
-
Notifications
You must be signed in to change notification settings - Fork 605
test(ui): Fix failing Jupyter test on Windows #8563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4a0b857
test: Try to fix failing UI test on Windows
hoxbro 913815f
mark as flaky
hoxbro 76e5d94
try wait for networkidle
hoxbro bccbc51
don't run jupyter test unless --jupyter is done
hoxbro 4dbb5e9
try more networkidle
hoxbro 5f1145e
wait for data-status to be idle
hoxbro 16cc423
Add wait step before running step
hoxbro 234c7a7
remove ifaxity/wait-on-action for curl
hoxbro 781bd34
more
hoxbro f9b8672
move the select kernel into the for loop
hoxbro edbaed9
mark specific test as flaky
hoxbro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,24 +42,26 @@ def launch_jupyterlite(): | |
| process.wait() | ||
|
|
||
|
|
||
| @pytest.mark.flaky(reruns=3, reruns_delay=5) | ||
| @pytest.mark.filterwarnings("ignore::ResourceWarning") | ||
| def test_jupyterlite_execution(launch_jupyterlite, page): | ||
| # INFO: Needs TS changes uploaded to CDN. Relevant when | ||
| # testing a new version of Bokeh. | ||
| page.goto("http://localhost:8123/index.html") | ||
| page.wait_for_load_state('networkidle') | ||
|
|
||
| page.locator('text="Getting_Started.ipynb"').first.dblclick() | ||
|
|
||
| # Select the kernel | ||
| if page.locator('.jp-Dialog').count() == 1: | ||
| page.locator('.jp-select-wrapper > select').select_option('Python (Pyodide)') | ||
| page.locator('.jp-Dialog-footer > button').nth(1).click() | ||
| page.wait_for_load_state('networkidle') | ||
|
|
||
| for _ in range(6): | ||
| page.locator('jp-button[data-command="notebook:run-cell-and-select-next"]').click() | ||
| page.wait_for_timeout(500) | ||
| if page.locator('.jp-Dialog').count() == 1: # Select the kernel if pop-up | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| page.locator('.jp-select-wrapper > select').select_option('Python (Pyodide)') | ||
| page.locator('.jp-Dialog-footer > button').nth(1).click() | ||
| page.wait_for_load_state('networkidle') | ||
| expect(page.locator('.jp-Notebook-ExecutionIndicator')).to_have_attribute('data-status', 'idle', timeout=60_000) | ||
|
|
||
| page.locator('.noUi-handle').click(timeout=120 * 1000) | ||
| page.locator('.noUi-handle').click() | ||
|
|
||
| page.keyboard.press('ArrowRight') | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -355,6 +355,7 @@ jupyterlab-myst = "*" | |
| jupyterlite-core = "<0.7.0" | ||
| jupyterlite-pyodide-kernel = "*" | ||
| python-build = "*" | ||
| python-libarchive-c = "*" | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| [feature.lite.tasks] | ||
| lite-build = "bash scripts/jupyterlite/build.sh" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to ignore the jupyter marked test when
--jupytermarker is not set.