Conversation
|
I fixed the systemd service file to support pulseaudio, this is the way to run gmrender-resurrect |
hzeller
left a comment
hzeller
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
I have essentially only one comment, making the choice of audio output system less dependent on what the output system happens to be, but make it a deliberate choice of the user.
| # audio. Otherwise, whatever default is configured for gstreamer for the | ||
| # '$DAEMON_USER' is used. | ||
| ALSA_DEVICE="sysdefault" | ||
| RET=`dpkg -l pulseaudio` |
There was a problem hiding this comment.
Here, you are making the choice of pulseaudio vs. Alsa dependent on the existence of a particular packet, which sounds like it will result in non-repeatable results: if accidentally a pulseaudio package is installed, suddenly the way gmrender works is changing, which can make things surprising.
So I suggest to rather have this as a variable at the top (USE_PULSEAUDIO=1 or something).
|
Did you get a chance to address the requested change ? |
3 participants
i also want to add the logrotate as I write a log in the service now.