fix: false error popup on Firefox mobile when opening downloads#1532
Open
bhushan4work wants to merge 1 commit intoimputnet:mainfrom
Open
fix: false error popup on Firefox mobile when opening downloads#1532bhushan4work wants to merge 1 commit intoimputnet:mainfrom
bhushan4work wants to merge 1 commit intoimputnet:mainfrom
Conversation
Author
|
please review and lemme know if any fix is needed further |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
window.open() return value is unreliable across browsers, especially Firefox mobile, where it may return null even when the tab opens successfully.
This caused a false "blocked" saving dialog to appear even when the download succeeded.
This change removes reliance on the return value of window.open(), preventing incorrect error dialogs.