feat: add scaffolding rollout workflow#1064
Conversation
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
garrett4wade
left a comment
garrett4wade
left a comment
There was a problem hiding this comment.
LGTM in general. Since the scaffolding module is relatively mature and not necessarily related to AReaL's core modules, I recommend to move all the new files into the examples directory. It'll be a complete and standalone example.
| if self.worker is None: | ||
| self._lazy_init_scaffolding(engine) |
There was a problem hiding this comment.
A new rollout workflow object is created for each trajectory. It will also create a ScaffoldingLlm object. Will this be very expensive?
Move code to the example. |
Key design: inclusionAI#818 Co-Authored-By: narutolhy Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
WeiHaocheng
force-pushed
the
scaffolding_pr
branch
from
18fb8cf to
8f904b3
Compare
garrett4wade
left a comment
garrett4wade
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the great contribution!
|
@WeiHaocheng Here～ |
3 participants
Description
Related Issue
Fixes #(issue)
Type of Change
Checklist
pre-commit run --all-files)./docs/build_all.sh)main/review-prcommand/create-prBreaking Change Details (if applicable):
Additional Context
Need help? Check the Contributing Guide or ask in
GitHub Discussions!