Add missing migration files for PRs #1153 and #1154 and remove Node.js 18 from CI templates#1157
Merged
Conversation
Co-authored-by: Apollon77 <11976694+Apollon77@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add missing migration files
Add missing migration files for PRs #1153 and #1154
Aug 31, 2025
Collaborator
|
@copilot Please do one additional change that was ,issed in the Node.js 18 removal PR: Please also remove 18.x from the Github CI template workflows |
Remove 18.x from adapterTestVersions array in GitHub workflow template to complete Node.js 18 support removal. Co-authored-by: Apollon77 <11976694+Apollon77@users.noreply.github.com>
Contributor
Author
Done! Removed 18.x from the GitHub CI template workflows in commit b498c22. This completes the Node.js 18 removal by ensuring that newly created adapters will only test against Node.js 20.x and 22.x versions. |
Copilot
AI
changed the title
Add missing migration files for PRs #1153 and #1154
Add missing migration files for PRs #1153 and #1154 and remove Node.js 18 from CI templates
Aug 31, 2025
Apollon77
approved these changes
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing migration documentation files for two recently merged PRs that made significant changes affecting adapter migration behavior, and completes the Node.js 18 removal by updating CI templates.
Background
PRs #1153 and #1154 introduced important changes to the adapter creator:
However, these PRs did not include the required migration documentation files in
docs/updates/that help users understand and apply these changes when migrating existing adapters. Additionally, the GitHub CI workflow templates still referenced Node.js 18.x.Changes Made
1. Added
20250831_jsonconfig_schema_url_fix.mdDocuments the jsonConfig schema URL change from the deprecated location in
adapter-react-v5to the official location inioBroker.admin:https://raw.githubusercontent.com/ioBroker/adapter-react-v5/main/schemas/jsonConfig.jsonhttps://raw.githubusercontent.com/ioBroker/ioBroker.admin/master/packages/jsonConfig/schemas/jsonConfig.jsonProvides step-by-step instructions for updating
.vscode/settings.jsonin existing adapters to use the correct schema for better IntelliSense and validation.2. Added
20250831_remove_nodejs18_support.mdDocuments the removal of Node.js 18 support and explains the automatic migration behavior:
package.jsonengines field3. Removed Node.js 18.x from GitHub CI Templates
Completed the Node.js 18 removal by removing
18.xfrom theadapterTestVersionsarray in the GitHub workflow template (templates/_github/workflows/test-and-release.yml.ts). This ensures newly created adapters will only test against Node.js 20.x and 22.x versions, fully aligning with the Node.js 18 support removal.Migration Documentation Format
All files follow the established conventions:
YYYYMMDD_description.md)Verification
Fixes #1156.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.