-
Notifications
You must be signed in to change notification settings - Fork 15
fix(android): separate local storage between WebView processes #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ItsChaceD
wants to merge
3
commits into
main
Choose a base branch
from
fix/RMET-4918/isolate-local-storage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import React, { useState, useEffect } from 'react'; | ||
| import { IonContent, IonHeader, IonPage, IonTitle, IonToolbar, IonButton, IonInput, IonItem, IonLabel, IonList, IonButtons, IonBackButton } from '@ionic/react'; | ||
|
|
||
| const LocalStorageTest: React.FC = () => { | ||
| const [value, setValue] = useState(''); | ||
| const [storedValue, setStoredValue] = useState<string | null>(null); | ||
|
|
||
| const refreshValue = () => { | ||
| const val = localStorage.getItem('inappbrowser_test_key'); | ||
| setStoredValue(val); | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| refreshValue(); | ||
| }, []); | ||
|
|
||
| const saveValue = () => { | ||
| localStorage.setItem('inappbrowser_test_key', value); | ||
| refreshValue(); | ||
| }; | ||
|
|
||
| const clearValue = () => { | ||
| localStorage.removeItem('inappbrowser_test_key'); | ||
| refreshValue(); | ||
| }; | ||
|
|
||
| return ( | ||
| <IonPage> | ||
| <IonHeader> | ||
| <IonToolbar> | ||
| <IonButtons slot="start"> | ||
| <IonBackButton defaultHref="/home" /> | ||
| </IonButtons> | ||
| <IonTitle>LocalStorage Test</IonTitle> | ||
| </IonToolbar> | ||
| </IonHeader> | ||
| <IonContent className="ion-padding"> | ||
| <IonList> | ||
| <IonItem> | ||
| <IonLabel position="stacked">Test Value</IonLabel> | ||
| <IonInput value={value} onIonChange={(e: any) => setValue(e.detail.value!)} placeholder="Enter value to store" /> | ||
| </IonItem> | ||
| </IonList> | ||
| <div style={{ marginTop: '20px' }}> | ||
| <IonButton expand="block" onClick={saveValue}>Save to LocalStorage</IonButton> | ||
| <IonButton expand="block" color="light" onClick={refreshValue}>Refresh from LocalStorage</IonButton> | ||
| <IonButton expand="block" color="danger" onClick={clearValue}>Clear LocalStorage</IonButton> | ||
| </div> | ||
|
|
||
| <div style={{ marginTop: '40px' }}> | ||
| <h3>Stored Value:</h3> | ||
| <p style={{ fontSize: '24px', fontWeight: 'bold' }}>{storedValue || '(none)'}</p> | ||
| </div> | ||
|
|
||
| <div style={{ marginTop: '20px', padding: '10px', backgroundColor: '#f0f0f0', borderRadius: '8px' }}> | ||
| <p><strong>Instructions:</strong></p> | ||
| <ol> | ||
| <li>Set a value here in the main app.</li> | ||
| <li>Go back and open this same page using "Open Site (InAppBrowser)".</li> | ||
| <li>Use the <strong>Enable Storage Isolation</strong> toggle to test different modes. | ||
| <ul> | ||
| <li><strong>On (Default)</strong>: Value should be "(none)".</li> | ||
| <li><strong>Off</strong>: Value should be shared.</li> | ||
| </ul> | ||
| </li> | ||
| </ol> | ||
| </div> | ||
| </IonContent> | ||
| </IonPage> | ||
| ); | ||
| }; | ||
|
|
||
| export default LocalStorageTest; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think
?: trueis needed here, sinceitis not nullable and getBoolean already returns a default value when the key doesn't exist.