Skip to content

chore: enable revive exported linter and add missing comments#8937

Open
Mallikarjunadevops wants to merge 1 commit intojenkins-x:mainfrom
Mallikarjunadevops:fix/lint-exported-comments-8037
Open

chore: enable revive exported linter and add missing comments#8937
Mallikarjunadevops wants to merge 1 commit intojenkins-x:mainfrom
Mallikarjunadevops:fix/lint-exported-comments-8037

Conversation

@Mallikarjunadevops
Copy link
Copy Markdown

Addresses #8037 by enabling the exported rule for the revive linter in .golangci.yml and fixing the exposed undocumented exported identifiers across the jx repository.

Changes:

  • Enabled exported rule for
    evive in .golangci.yml.
  • Added missing comments in:
    • pkg/cmd/version/version.go
    • pkg/cmd/namespace/namespace.go
    • pkg/cmd/dashboard/dashboard.go
    • pkg/cmd/upgrade/upgrade.go, upgrade_cli.go, upgrade_plugins.go
    • pkg/plugins/helpers.go

Fixes: #8037

Addresses jenkins-x#8037 by enabling the exported rule for the revive linter in .golangci.yml and fixing the exposed undocumented exported identifiers.

Signed-off-by: Mallikarjunadevops <mallikarjunadevops@example.com>
@jenkins-x-bot
Copy link
Copy Markdown
Contributor

Hi @Mallikarjunadevops. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jenkins-x-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jordangoasdoue
You can assign the PR to them by writing /assign @jordangoasdoue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linting checks pass even if exported structs do not have any comments

2 participants