fix: harden session restore against malformed persisted JSON (fixes #304)#305
Open
Flamki wants to merge 1 commit intojenkinsci:mainfrom
Open
fix: harden session restore against malformed persisted JSON (fixes #304)#305Flamki wants to merge 1 commit intojenkinsci:mainfrom
Flamki wants to merge 1 commit intojenkinsci:mainfrom
Conversation
This was referenced Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304.
This change makes session restore more resilient when a persisted session file is corrupted.
What was happening
load_session()read JSON directly from disk. If one session file was malformed (for example truncated JSON), restore could fail on that file and affect startup/session reload flow.What this PR changes
chatbot-core/api/services/sessionmanager.py:_load_session_from_json().OSError) or JSON is invalid (JSONDecodeError), we now log a warning and return[].[].chatbot-core/tests/unit/services/test_sessionmanager.py:reload_persisted_sessions()restores valid files and skips malformed ones.Scope
Session persistence robustness only. No change to reply generation or endpoint contracts.
Verification
pytest chatbot-core/tests/unit/services/test_sessionmanager.py -qpytest chatbot-core/tests/unit/services/test_memory.py -qpylint chatbot-core/api/services/sessionmanager.py chatbot-core/tests/unit/services/test_sessionmanager.py