Skip to content

Create Application Version Evidence#7

Merged
dortam888 merged 8 commits intomainfrom
application-version-evidence-create
Sep 25, 2025
Merged

Create Application Version Evidence#7
dortam888 merged 8 commits intomainfrom
application-version-evidence-create

Conversation

@dortam888
Copy link
Copy Markdown
Contributor

@dortam888 dortam888 commented Sep 15, 2025 •
edited
Loading

Pull Request Template

Description

Add support for application-version in jf evd create command.

Depend on:
jfrog/jfrog-cli-core#1449
jfrog/jfrog-client-go#1197

Related Issue

Testing

  • Tests added/updated
  • All tests pass locally

Checklist

  • PR description is clear and concise, and it includes the proposed solution/fix
  • Code follows project style guidelines
  • Documentation updated (if applicable)

@dortam888 dortam888 added the feature New feature or functionality label Sep 15, 2025
@dortam888 dortam888 force-pushed the application-version-evidence-create branch from 064fdeb to 037d567 Compare September 15, 2025 23:03
alenon
alenon reviewed Sep 16, 2025
View reviewed changes
Comment thread evidence/cli/command_application.go
mnsboev
mnsboev requested changes Sep 16, 2025
View reviewed changes
Comment thread evidence/create/create_application.go
alenon
alenon reviewed Sep 16, 2025
View reviewed changes
Comment thread evidence/cli/command_application.go Outdated
Comment thread evidence/cli/command_application.go Outdated
Comment thread evidence/create/create_application.go Outdated
alenon
alenon reviewed Sep 16, 2025
View reviewed changes
Comment thread evidence/utils/repo_key_builder.go Outdated
@dortam888
Update dependencies and fix PromotionStatus usage
e7c25e1 
- Updated jfrog-client-go to v1.28.3 with ApptrustServiceManagerInterface
- Updated jfrog-cli-core to v2.59.10 with interface compatibility fix
- Fixed PromotionStatus usage to use typed constant instead of string
- All tests passing successfully

Changes include:
- Updated go.mod replace directives for both dependencies
- Added apptrust/services import for PromotionStatus constants
- Fixed type comparison for promotion.Status == services.PromotionStatusCompleted
- Verified compatibility with new interface-based design
@dortam888
Update dependencies after interface revert
b816e8e 
- Updated jfrog-client-go to v1.28.4 (reverted to concrete type)
- Updated jfrog-cli-core to v2.59.11 (compatible with concrete type)
- All tests passing with reverted interface implementation
- PromotionStatus usage remains with typed constants
@dortam888 dortam888 force-pushed the application-version-evidence-create branch from 7371572 to d545a6b Compare September 20, 2025 22:17
alenon
alenon reviewed Sep 21, 2025
View reviewed changes
Comment thread evidence/cli/command_custom.go Outdated
Comment thread go.mod Outdated
alenon
alenon reviewed Sep 25, 2025
View reviewed changes
Comment thread evidence/cli/command_build.go
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 25, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

@dortam888 dortam888 merged commit e2aeae3 into main Sep 25, 2025
15 checks passed
@dortam888 dortam888 deleted the application-version-evidence-create branch September 25, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alenon alenon alenon approved these changes

@mnsboev mnsboev mnsboev approved these changes

Assignees

No one assigned

Labels

feature New feature or functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dortam888 @alenon @mnsboev