Added customNetwork to TokensFactoryPublic constructor, Added option to skip the quote observer, Removed Ropsten Chain#55
Open
niZmosis wants to merge 25 commits intojoshstevens19:masterfrom
Open
Conversation
added 3 commits
November 13, 2022 20:54
Added option to skip the quote watcher Removed Ropsten Chain
Renamed disableWatcher to disableObserver
Added playground example for manual requoting
Added Sepolia for when Uniswap supports the chain.
FIxed replacement ethereumAddress in example, put a token address in by accident
Added configurations for Arbitrum, Celo, and Optimism
Author
|
@joshstevens19 Hey, could you review this PR when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added customNetwork to TokensFactoryPublic:
Fix for issue #41
Added a playground method for testing getAllowanceAndBalanceOfForContracts on a custom network
Added option to skip the quote observer:
Option to prevent the library from adding the block listener, as when it's finished it removes all listeners of 'block', which may affect front end dApps. When true, It's up to the dev to listen for new blocks and update the quote using the new requote function on the UniswapPairFactory obj.
Bound the block listener which observes the quote, to its class instance. This will prevent all block listeners from being removed when a quote is destroyed. There may be a way to make the binding async, but I'm not sure.
Removed Ropsten Chain: Ropsten Chain has been deprecated
Removed Rinkeby Chain: Rinkeby Chain has been deprecated
Removed Kovan Chain: Kovan Chain has been deprecated
Added Sepolia Chain: WIP by Uniswap team to deploy the contracts on this chain still.