This repository was archived by the owner on Apr 24, 2025. It is now read-only.
✨ Add isOneShot for Alexa request#1628
Open
sadlowskij wants to merge 3 commits intojovotech:v4/devfrom
Open
Conversation
aswetlow
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This adds a function to check for so called one shots. Is this something that would be useful? We sometimes differ how we answer depending on if it is a oneshot or not.
Theoretically this is not exclusive to the alexa platform and could just as well be implemented in the normal JovoRequest. I am not sure though, if this always makes sense, or if the terminology and usefulness binds this to alexa. Feel free to tell me if you find this useful, and if so, where.
Types of Changes
Checklist