Modified project to cross-compile to scala 3 and 2#97
Open
javierfvargas wants to merge 1 commit intojulienrf:masterfrom
Open
Modified project to cross-compile to scala 3 and 2#97javierfvargas wants to merge 1 commit intojulienrf:masterfrom
javierfvargas wants to merge 1 commit intojulienrf:masterfrom
Conversation
…sal for scala 3 using macros instead of shapeless.
Owner
|
Thank you @javierfvargas for opening the PR! I didn’t have a look at the implementation yet but it seems there is a test failure: It looks like the discriminator name is not correct. Could you please investigate this CI failure? |
Open
Author
|
@julienrf pls have a little patience. I am traveling with my company and additionally I found some issues when I decided to switch to a more recent scala version. It seems the compiler got stricter and requires the code to be different. I think it is a good idea to understand what should be different and be sure to include it in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for scala 3 using macros instead of shapeless.
I'd suggest moving sbt version even upward and as part of my ignorance I added this line
ThisBuild / version := "11.0.0-local"
Of course it has to be removed, just left it there so that you can check it locally.
If you guide me on your coding standards I am happy to help. Maybe insteade of requesting this PR to master you could create a mirror branch and we work on a PR to that branch.