Support http-configurable and nginx reverse proxy#136
Open
hungdinhxuan wants to merge 3 commits intojupyterhub:mainfrom
Open
Support http-configurable and nginx reverse proxy#136hungdinhxuan wants to merge 3 commits intojupyterhub:mainfrom
hungdinhxuan wants to merge 3 commits intojupyterhub:mainfrom
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Member
|
Thanks for the PR! I think it'd be good to keep the basic example as simple as possible, but this would make a nice second example. Would you mind adding a new directory (you can probably just copy all the files from basic-example into that new directory), and add the directory to the test matrix? jupyterhub-deploy-docker/.github/workflows/test.yml Lines 31 to 34 in e31f3a5 |
29c43b7 to
511bac6
Compare
b0926d5 to
5bbe8c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.