Skip to content

[WIP]feat(ui): add CategorizedManageColumnsModal with Cypress tests for hardware config table#2632

Open
YuliaKrimerman wants to merge 1 commit intokubeflow:mainfrom
YuliaKrimerman:categorized-manage-columns
Open

[WIP]feat(ui): add CategorizedManageColumnsModal with Cypress tests for hardware config table#2632
YuliaKrimerman wants to merge 1 commit intokubeflow:mainfrom
YuliaKrimerman:categorized-manage-columns

Conversation

@YuliaKrimerman
Copy link
Copy Markdown
Contributor

Description

Replaces the generic ManageColumnsModal from mod-arch-shared with a new CategorizedManageColumnsModal component for the hardware configuration table on the Performance Insights tab. The new modal organizes the 22+ manageable columns into categorized expandable sections (General, TTFT Latency, E2E Latency, ITL Latency, Throughput TPS), making it much easier for users to find and toggle columns.

Changes

New component — CategorizedManageColumnsModal:

  • Expandable category sections with drag-drop reordering within each section
  • Column search/filter across all categories
  • Selected count display and "Restore default columns" button
  • Category descriptions via help icon popovers
  • Empty state when search yields no results
  • Proper data-testid attributes on all interactive elements

How Has This Been Tested?

  • Cypress E2E tests: 27 mocked tests covering all modal interactions (manageColumns.cy.ts)
    npm run test:cypress-ci -- --headed --no-exit --spec '**/modelCatalog/manageColumns.cy.ts'

Signed-off-by: Yulia Krimerman <juliapiterova@hotmail.com>
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yuliakrimerman. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot requested a review from fege April 23, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant