feat: Replace endpoints with endpointslices as default resource#2659
feat: Replace endpoints with endpointslices as default resource#2659k8s-ci-robot merged 1 commit intokubernetes:mainfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/S
mrueg
force-pushed
the
epslices
branch
2 times, most recently
from
9852c11 to
152697f
Compare
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
I see, this moves It'd additionally make sense to put this behind a flag, and enable it by default once the deprecation deadline hits. This way, users can start opt-ing into the feature before it's dropped. |
|
/lgtm /hold Feel free to unhold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
lgtm
BREAKING CHANGE: endpoints are not a default resource anymore and metrics need to be replaced with endpointslices' metrics. https://kubernetes.io/blog/2025/04/23/kubernetes-v1-33-release/#deprecation-of-the-stable-endpoints-api.
|
/hold cancel @rexagod @CatherineF-dev @dgrisonnet can I get a review here again? Thanks! |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@rexagod @CatherineF-dev can I get a review for this? |
|
@rexagod @CatherineF-dev @dgrisonnet can I get another review here? I would like to get this change in for the next release. |
|
Can this get reviewed please, it spams a load of warnings in our clusters now that we'd want to get cleaned up before upgrading EKS. |
| tar xvz --strip-components=1 prometheus-${PROMETHEUS_VERSION}.${OS}-${ARCH}/promtool | ||
|
|
||
| .PHONY: all build build-local all-push all-container container container-* do-push-* sub-push-* push push-multi-arch test-unit test-rules test-benchmark-compare clean e2e validate-modules shellcheck licensecheck lint lint-fix generate generate-template validate-template embedmd | ||
| .PHONY: all build build-local all-push all-container container container-* do-push-* sub-push-* push push-multi-arch test-unit test-rules test-benchmark-compare clean e2e validate-modules shellcheck licensecheck lint lint-fix generate generate-template validate-template |
There was a problem hiding this comment.
Unrelated but I believe embedmd should happen with each generate? We could probably drop this change from this PR and open a new one to fix this target.
There was a problem hiding this comment.
@mrueg I would like to do it for you if you are busy on something :)
There was a problem hiding this comment.
It's happening with each generate, running ${EMBEDMD_CLI} -w find . -path ./vendor -prune -o -name "*.md" -print
rexagod
moved this from Needs Review (PR) or Response (Issue)
to Backlog (stale)
in SIG Instrumentation
|
/lgtm |
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CatherineF-dev, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel thanks for the review @CatherineF-dev |
k8s-ci-robot
removed
the
do-not-merge/hold
github-project-automation
Bot
moved this from Backlog (stale)
to Done
in SIG Instrumentation
7 participants
What this PR does / why we need it:
BREAKING CHANGE: endpoints are not a default resource anymore and metrics need to be replaced with endpointslices' metrics.
https://kubernetes.io/blog/2025/04/23/kubernetes-v1-33-release/#deprecation-of-the-stable-endpoints-api.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
None
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #