Skip to content

fix(cronjob): replace panic on timezone load failure with graceful error skip #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aryanputta wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

fix(cronjob): replace panic on timezone load failure with graceful error skip #2907

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc560c6
cronjob: replace panic on timezone parse error with logged error and …
aryanputta Mar 25, 2026
8f15c4f
Update cronjob.go
aryanputta Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions internal/store/cronjob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ import (
"k8s.io/client-go/tools/cache"
basemetrics "k8s.io/component-base/metrics"

"k8s.io/klog/v2"

"k8s.io/kube-state-metrics/v2/pkg/metric"
generator "k8s.io/kube-state-metrics/v2/pkg/metric_generator"
)
Expand Down Expand Up @@ -251,8 +253,10 @@ func cronJobMetricFamilies(allowAnnotationsList, allowLabelsList []string) []gen
// If the cron job is suspended, don't track the next scheduled time
nextScheduledTime, err := getNextScheduledTime(j.Spec.Schedule, j.Status.LastScheduleTime, j.CreationTimestamp, j.Spec.TimeZone)
if err != nil {
panic(err)
} else if !*j.Spec.Suspend {
klog.Errorf("failed to compute next schedule time for cronjob %s/%s: %v", j.Namespace, j.Name, err)
Comment thread
aryanputta marked this conversation as resolved.
Outdated
return &metric.Family{Metrics: ms}
}
Comment thread
aryanputta marked this conversation as resolved.
if !*j.Spec.Suspend {
ms = append(ms, &metric.Metric{
Comment thread
aryanputta marked this conversation as resolved.
LabelKeys: []string{},
LabelValues: []string{},
Expand Down
Loading