Skip to content

fix: Ignore non-served CRD versions in discovery#2940

Open
boomer41 wants to merge 1 commit intokubernetes:mainfrom
boomer41:bs/fix-crd-discovery
Open

fix: Ignore non-served CRD versions in discovery#2940
boomer41 wants to merge 1 commit intokubernetes:mainfrom
boomer41:bs/fix-crd-discovery

Conversation

@boomer41
Copy link
Copy Markdown

What this PR does / why we need it:

When an API version is still available, but not served by the API server, any usage of that will result in errors.
Thus, ignore the CRD versions that are not served.

This happened with ExternalSecrets.
It still adds v1beta1 to the CRD definition, but sets it as non-stored and non-served.
If you have the version for Kube State Metrics set to *, it will repeatedly fail with the following message:

"Failed to watch" err="failed to list external-secrets.io/v1beta1, Kind=ExternalSecret: the server could not find the requested resource" logger="UnhandledError" reflector="pkg/mod/k8s.io/client-go@v0.34.3/tools/cache/reflector.go:290" type="external-secrets.io/v1beta1, Kind=ExternalSecret"

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

It removes CRD versions from the discovery which are not served by the API server (and any request will fail), but still defined in the CRD.

Which issue(s) this PR fixes: (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)
Fixes #

When an API version is still available, but not served by the API server,
any usage of that will result in errors.
Thus, ignore the CRD versions that are not served.
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: boomer41
Once this PR has been reviewed and has the lgtm label, please assign mrueg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 28, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: boomer41 / name: Stephan Brunner (1932d59)

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 28, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @boomer41!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants