Skip to content

Migrate GCP permissions#6268

Open
hajiler wants to merge 1 commit intokubernetes:mainfrom
hajiler:remove-outdated-permissions
Open

Migrate GCP permissions#6268
hajiler wants to merge 1 commit intokubernetes:mainfrom
hajiler:remove-outdated-permissions

Conversation

@hajiler
Copy link
Copy Markdown
Contributor

@hajiler hajiler commented Apr 3, 2026

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject sig/storage Categorizes an issue or PR as relevant to SIG Storage. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 3, 2026

Hi @hajiler. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2026
@mattcary
Copy link
Copy Markdown
Contributor

mattcary commented Apr 3, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2026
@hajiler
Copy link
Copy Markdown
Contributor Author

hajiler commented Apr 3, 2026

/assign saad-ali

@hajiler hajiler force-pushed the remove-outdated-permissions branch from 039b974 to 35ca4cc Compare April 10, 2026 17:58
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 10, 2026
@hajiler hajiler force-pushed the remove-outdated-permissions branch from 35ca4cc to e074667 Compare April 10, 2026 17:59
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2026
@hajiler hajiler changed the title Remove ex members of pdcsi team Migrate GCP permissions Apr 10, 2026
@msau42
Copy link
Copy Markdown
Member

msau42 commented Apr 10, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2026
@msau42
Copy link
Copy Markdown
Member

msau42 commented Apr 10, 2026

/lgtm cancel

Sorry I got it wrong, I think it's

org/config/kubernetes/provider-gcp/teams.yaml

Line 4 in 4ecb20c

members:
we want to move it to

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2026
@msau42
Copy link
Copy Markdown
Member

msau42 commented Apr 10, 2026

But I think the teams file has to be under the right org. So maybe we need to create a provider-gcp folder under kubernetes-sigs.

@hajiler hajiler force-pushed the remove-outdated-permissions branch from e074667 to 4b34056 Compare April 10, 2026 20:44
@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label Apr 10, 2026
@hajiler hajiler force-pushed the remove-outdated-permissions branch from 4b34056 to da838ca Compare April 17, 2026 19:45
@msau42
Copy link
Copy Markdown
Member

msau42 commented Apr 17, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2026
@hajiler hajiler force-pushed the remove-outdated-permissions branch from da838ca to 7e247d2 Compare April 24, 2026 15:08
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2026
@hajiler
Copy link
Copy Markdown
Contributor Author

hajiler commented Apr 27, 2026

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 27, 2026

@hajiler: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hajiler
Copy link
Copy Markdown
Contributor Author

hajiler commented May 1, 2026

/ok-to-test

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 1, 2026

@hajiler: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@msau42
Copy link
Copy Markdown
Member

msau42 commented May 1, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 1, 2026
@msau42
Copy link
Copy Markdown
Member

msau42 commented May 2, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hajiler, mattcary, msau42
Once this PR has been reviewed and has the lgtm label, please assign priyankasaggu11929 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@saad-ali saad-ali

@msau42 msau42

@mattcary mattcary

Labels

area/github-management Issues or PRs related to GitHub Management subproject area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hajiler @k8s-ci-robot @mattcary @msau42 @saad-ali