Skip to content

NO-JIRA | chore: update planner-sdk to latest version that includes changes related with time estimation#570

Merged
ammont82 merged 1 commit intokubev2v:masterfrom
ammont82:adapting-ui-to-api-changes-time-estimation
Apr 14, 2026
Merged

NO-JIRA | chore: update planner-sdk to latest version that includes changes related with time estimation#570
ammont82 merged 1 commit intokubev2v:masterfrom
ammont82:adapting-ui-to-api-changes-time-estimation

Conversation

@ammont82
Copy link
Copy Markdown
Collaborator

@ammont82 ammont82 commented Apr 14, 2026

Update planner-sdk to latest version and update the related code

Summary by CodeRabbit

  • Chores
    • Updated SDK dependency version
  • Refactor
    • Updated migration estimation calculation handling in cluster sizing wizard to align with SDK API changes

…related code

Signed-off-by: Montse Ortega <mortegag@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

📝 Walkthrough

Walkthrough

The pull request updates the @openshift-migration-advisor/planner-sdk dependency to a build-tagged version and refactors migration estimation types across the codebase. The return type of calculateMigrationEstimation() is changed to MigrationEstimationResponse, with corresponding type adjustments in the view model and re-exports from the external SDK.

Changes

Cohort / File(s) Summary
Dependency Update
package.json
Updated @openshift-migration-advisor/planner-sdk from 0.10.0 to 0.10.0-783d8b3a2dc4 (build-tagged variant).
Interface Type Signature
src/data/stores/interfaces/IAssessmentsStore.ts
Changed calculateMigrationEstimation() return type from Promise<Record<string, SchemaEstimationResult>> to Promise<MigrationEstimationResponse> and updated corresponding import.
View Model Type & Logic
src/ui/report/view-models/useClusterSizingWizardViewModel.ts
Updated migrationEstimation property type from MigrationEstimationResponse | null to Record<string, SchemaEstimationResult> | null; modified processing logic to extract result?.estimation into schemas variable before storage.
Type Re-exports
src/ui/report/views/cluster-sizer/types.ts
Removed local MigrationEstimationResponse type alias and now re-export it directly from @openshift-migration-advisor/planner-sdk; removed unused SchemaEstimationResult import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • machacekondra
  • bardielle
  • nirarg

Poem

🐰 A hop, a skip, types realigned,
The planner-sdk's new home we find,
From local alias to import true,
MigrationEstimation shines anew! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly describes the main change: updating the planner-sdk dependency to a newer version that includes time estimation-related changes, which is reflected in all four modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ammont82
Copy link
Copy Markdown
Collaborator Author

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 changed the title NO-JIRA | chore: update planner-sdk to latest version and update the related code NO-JIRA | chore: update planner-sdk to latest version that includes changes related with time estimation Apr 14, 2026
@ammont82 ammont82 merged commit f02a040 into kubev2v:master Apr 14, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant