Conversation
viniarck
requested changes
Jan 27, 2026
Member
viniarck
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @Alopalao, it's in the right direction but it's caused other issues. start_shell_async has to run after controller.start() coro, otherwise it'll crash due to server attrs dependency it access, and the shell won't start correctly:
shell_task: <Task finished name='Task-1' coro=<start_shell_async() done, defined at /home/viniarck/repos/kytos/kytos/core/kytosd.py:136> exception=AttributeError("'NoneType' object has no attribute 'server_address'")>
Try moving shell_task after controller.start(), and then make sure to explore all the related cases that you've been fixing and exploring
Author
|
I misunderstood the use of
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #601
Summary
Starting controller after adding the signals.
Local Tests
Excercise this PR with wrong values in
settings.pysomef_elinewould failed start.End-to-End Tests
N/A