fix: add missing `initHeartbeats` by eric-wieser · Pull Request #1037 · leanprover-community/batteries

eric-wieser · 2024-11-11T17:53:12Z

In only one case a Core.Context is created from within CoreM, and we inherit from the parent Context the initHeartbeats. Otherwise, we get the current heartbeats from IO.

It's not entirely clear to me what the intended semantics of lintCore are; should they inherit the outer heartbeat count (as with this patch), or get a new heartbeat budget for each declaration (prior to it)?

ghost · 2024-11-11T18:35:45Z

Mathlib CI status (docs):

✅ Mathlib branch batteries-pr-testing-1037 has successfully built against this PR. (2024-11-11 18:35:44) View Log
✅ Mathlib branch batteries-pr-testing-1037 has successfully built against this PR. (2025-01-18 07:20:58) View Log
✅ Mathlib branch batteries-pr-testing-1037 has successfully built against this PR. (2026-01-26 15:40:01) View Log

fgdorais · 2024-11-13T03:43:07Z

LGTM Could you explain, for documentation purposes, why this isn't something Lean core could do?

eric-wieser · 2025-01-02T13:22:31Z

Sorry, I missed that message.

What are you expecting Lean core to do here? Because we are constructing a Lean.Core.Context manually from scratch, it's our responsibility to fill in all of its fields.

Perhaps @kmill should have a look at this and suggest if we can avoid this manual construction in the first place (and confirm whether the PR in its current state is still an improvement over the status quo).

kmill · 2025-01-02T16:04:00Z

Batteries/Tactic/Lint/Frontend.lean

          match ← withCurrHeartbeats (linter.test decl)
              |>.run' mkMetaContext
-              |>.run' {options, fileName := "", fileMap := default} {env}
+              |>.run' {options, fileName := "", fileMap := default, initHeartbeats } {env}


It looks like the withCurrHeartbeats sets initHeartbeats from IO.getNumHeartbeats. What effect does initializing initHeartbeats here have? Can you come up with a test that validates this?

I think you're right, this has no effect.

kmill · 2025-01-02T17:02:35Z

Batteries/Util/Cache.lean

+      let initHeartbeats ← IO.getNumHeartbeats
      let res ← EIO.asTask <|
-        init {} |>.run' {} { options, fileName, fileMap } |>.run' { env }
+        init {} |>.run' {} { options, fileName, fileMap, initHeartbeats } |>.run' { env }


I see that Lean.Core.wrapAsync exists, and it does a bit more heartbeats arithmetic. Lean.Core.CoreM.toIO looks relevant.

wrapAsync indeed looks like the right tool, as otherwise the hearbeat counts on one thread are meaninglessly transferred to another thread.

In only one case a `Core.Context` is created from within CoreM, and we inherit from the parent Context the `initHeartbeats`. Otherwise, we get the current heartbeats from IO. Co-authored-by: Laurent Sartran <lsartran@google.com>

fgdorais · 2025-01-18T06:37:51Z

Have issues been fixed to everyone's satisfaction?

fgdorais · 2025-02-16T03:39:03Z

I'm afraid I lost track of this one. What's the current status?

eric-wieser · 2025-02-16T11:27:16Z

I need to update the description to reflect the new version, but I think the approach now aligns with @kmill's suggestion.

The mathlib failure suggests that either I have broken the heartbeat counting, or that we were previously erroneously resetting the heartbeat counter mid-linter.

…rover-community/batteries into eric-wieser/initHeartbeats

eric-wieser · 2026-01-26T07:10:34Z

Do I need to do anything here to get mathlib to build with this change?

Co-authored-by: Laurent Sartran <lsartran@google.com> Co-authored-by: F. G. Dorais <fgdorais@gmail.com>

github-actions bot added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Nov 11, 2024

ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Nov 11, 2024

Update Batteries branch for testing leanprover-community/batteries#1037

23b6a5c

ghost added the builds-mathlib label Nov 11, 2024

fgdorais added awaiting-author Waiting for PR author to address issues and removed awaiting-review This PR is ready for review; the author thinks it is ready to be merged. labels Nov 26, 2024

ghost added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Dec 2, 2024

kmill reviewed Jan 2, 2025

View reviewed changes

eric-wieser and others added 2 commits January 8, 2025 15:20

fix: add missing initHeartbeats

4597aea

In only one case a `Core.Context` is created from within CoreM, and we inherit from the parent Context the `initHeartbeats`. Otherwise, we get the current heartbeats from IO. Co-authored-by: Laurent Sartran <lsartran@google.com>

rework

9d7fca8

eric-wieser force-pushed the eric-wieser/initHeartbeats branch from c753fca to 9d7fca8 Compare January 8, 2025 15:21

ghost removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Jan 8, 2025

chore: merge main and fix long line

bd741cd

ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jan 18, 2025

Trigger CI for leanprover-community/batteries#1037

7488e57

ghost added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Dec 31, 2025

eric-wieser and others added 5 commits January 26, 2026 06:28

Merge tag 'v4.27.0' into eric-wieser/initHeartbeats

a3c2c3e

Merge branch 'main' into eric-wieser/initHeartbeats

8149524

partially fix

79b7f44

fix

74ac945

Merge branch 'eric-wieser/initHeartbeats' of https://github.com/leanp…

218b6ff

…rover-community/batteries into eric-wieser/initHeartbeats

eric-wieser removed awaiting-author Waiting for PR author to address issues merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. labels Jan 26, 2026

fgdorais added this pull request to the merge queue Feb 13, 2026

Merged via the queue into main with commit 450ddfd Feb 13, 2026
2 checks passed

fgdorais added a commit that referenced this pull request Feb 26, 2026

fix: add missing initHeartbeats (#1037)

0d0e5d3

Co-authored-by: Laurent Sartran <lsartran@google.com> Co-authored-by: F. G. Dorais <fgdorais@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add missing `initHeartbeats`#1037

fix: add missing `initHeartbeats`#1037
fgdorais merged 8 commits intomainfrom
eric-wieser/initHeartbeats

eric-wieser commented Nov 11, 2024

Uh oh!

ghost commented Nov 11, 2024 •

edited by ghost

Loading

Uh oh!

fgdorais commented Nov 13, 2024

Uh oh!

eric-wieser commented Jan 2, 2025

Uh oh!

kmill Jan 2, 2025

Uh oh!

eric-wieser Jan 8, 2025

Uh oh!

kmill Jan 2, 2025

Uh oh!

eric-wieser Jan 8, 2025

Uh oh!

fgdorais commented Jan 18, 2025

Uh oh!

fgdorais commented Feb 16, 2025

Uh oh!

eric-wieser commented Feb 16, 2025

Uh oh!

eric-wieser commented Jan 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

eric-wieser commented Nov 11, 2024

Uh oh!

ghost commented Nov 11, 2024 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fgdorais commented Nov 13, 2024

Uh oh!

eric-wieser commented Jan 2, 2025

Uh oh!

kmill Jan 2, 2025

Choose a reason for hiding this comment

Uh oh!

eric-wieser Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

kmill Jan 2, 2025

Choose a reason for hiding this comment

Uh oh!

eric-wieser Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

fgdorais commented Jan 18, 2025

Uh oh!

fgdorais commented Feb 16, 2025

Uh oh!

eric-wieser commented Feb 16, 2025

Uh oh!

eric-wieser commented Jan 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ghost commented Nov 11, 2024 •

edited by ghost

Loading