fix: address shellcheck warnings in create-adaptation-pr.sh#1624
Merged
fix: address shellcheck warnings in create-adaptation-pr.sh#1624
Conversation
github-actions
bot
added
the
awaiting-review
ghost
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 23, 2026
Addresses all shellcheck warnings in `scripts/create-adaptation-pr.sh`: - Quote variables to prevent globbing/word splitting (SC2086) - Use `$(...)` instead of legacy backticks (SC2006) - Add `-r` flag to `read` commands (SC2162) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
kim-em
force-pushed
the
fix-shellcheck-warnings
branch
from
d551267 to
51fd6a3
Compare
ghost
added
the
|
Mathlib CI status (docs):
|
fgdorais
approved these changes
Jan 23, 2026
github-actions
bot
removed
the
awaiting-review
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 27, 2026
This PR addresses all shellcheck warnings in `scripts/create-adaptation-pr.sh`: - Quote variables to prevent globbing/word splitting ([SC2086](https://www.shellcheck.net/wiki/SC2086)) - Use `$(...)` instead of legacy backticks ([SC2006](https://www.shellcheck.net/wiki/SC2006)) - Add `-r` flag to `read` commands ([SC2162](https://www.shellcheck.net/wiki/SC2162)) **Related PRs:** - leanprover/cslib#203 (cslib) - leanprover-community/batteries#1624 (batteries) 🤖 Prepared with Claude Code
YellPika
pushed a commit
to YellPika/mathlib4
that referenced
this pull request
Feb 3, 2026
…er-community#34286) This PR addresses all shellcheck warnings in `scripts/create-adaptation-pr.sh`: - Quote variables to prevent globbing/word splitting ([SC2086](https://www.shellcheck.net/wiki/SC2086)) - Use `$(...)` instead of legacy backticks ([SC2006](https://www.shellcheck.net/wiki/SC2006)) - Add `-r` flag to `read` commands ([SC2162](https://www.shellcheck.net/wiki/SC2162)) **Related PRs:** - leanprover/cslib#203 (cslib) - leanprover-community/batteries#1624 (batteries) 🤖 Prepared with Claude Code
fgdorais
pushed a commit
that referenced
this pull request
Feb 26, 2026
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses all shellcheck warnings in
scripts/create-adaptation-pr.sh:$(...)instead of legacy backticks (SC2006)-rflag toreadcommands (SC2162)Related PRs:
🤖 Prepared with Claude Code