fix: prevent duplicate Zulip posts in nightly failure workflow#1630
Merged
fix: prevent duplicate Zulip posts in nightly failure workflow#1630
Conversation
The deduplication logic compared the first 160 characters of the message, but the GitHub Actions run ID appears within those characters. Different workflow runs have different IDs, so duplicates were posted for the same nightly date. Now we extract and compare the nightly date and bump branch explicitly using regex, which correctly identifies duplicate messages. 🤖 Prepared with Claude Code Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
the
awaiting-review
ghost
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 25, 2026
ghost
added
the
|
Mathlib CI status (docs):
|
github-actions
bot
removed
the
awaiting-review
fgdorais
pushed a commit
that referenced
this pull request
Feb 26, 2026
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
nightly_detect_failure.ymlworkflow where duplicate messages were being posted to Zulip for the same nightly date.The deduplication logic compared the first 160 characters of the message, but the GitHub Actions run ID appears within those characters. Different workflow runs have different IDs, so the comparison always failed and duplicates were posted.
Now we extract and compare the nightly date and bump branch explicitly using regex, which correctly identifies duplicate messages.
See https://leanprover.zulipchat.com/#narrow/channel/428973-nightly-testing/topic/Cslib.20bump.20branch.20reminders/near/569853848 for context.
🤖 Prepared with Claude Code