fix: IsChain style improvements and deprecation correction#1663
Merged
fgdorais merged 6 commits intoleanprover-community:mainfrom Feb 13, 2026
Merged
fix: IsChain style improvements and deprecation correction#1663fgdorais merged 6 commits intoleanprover-community:mainfrom
fgdorais merged 6 commits intoleanprover-community:mainfrom
Conversation
github-actions
bot
added
the
awaiting-review
fgdorais
added a commit
to fgdorais/mathlib4
that referenced
this pull request
Feb 10, 2026
4 tasks
fgdorais
reviewed
Feb 11, 2026
mathlib-nightly-testing bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Feb 12, 2026
Co-authored-by: François G. Dorais <fgdorais@gmail.com>
4 tasks
github-actions
bot
removed
the
awaiting-review
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 13, 2026
After [batteries#1663](leanprover-community/batteries#1663) is merged: - [x] Merge leanprover-community/mathlib4:master - [x] Edit the lakefile to point to leanprover-community/batteries:main - [x] Run lake update batteries - [ ] Wait for CI and merge Co-authored-by: mathlib-nightly-testing[bot] <mathlib-nightly-testing[bot]@users.noreply.github.com> Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 13, 2026
After [batteries#1663](leanprover-community/batteries#1663) is merged: - [x] Merge leanprover-community/mathlib4:master - [x] Edit the lakefile to point to leanprover-community/batteries:main - [x] Run lake update batteries - [ ] Wait for CI and merge Co-authored-by: mathlib-nightly-testing[bot] <mathlib-nightly-testing[bot]@users.noreply.github.com> Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
kim-em
pushed a commit
to kim-em/mathlib4
that referenced
this pull request
Feb 14, 2026
After [batteries#1663](leanprover-community/batteries#1663) is merged: - [x] Merge leanprover-community/mathlib4:master - [x] Edit the lakefile to point to leanprover-community/batteries:main - [x] Run lake update batteries - [ ] Wait for CI and merge Co-authored-by: mathlib-nightly-testing[bot] <mathlib-nightly-testing[bot]@users.noreply.github.com> Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
rao107
pushed a commit
to rao107/mathlib4
that referenced
this pull request
Feb 18, 2026
After [batteries#1663](leanprover-community/batteries#1663) is merged: - [x] Merge leanprover-community/mathlib4:master - [x] Edit the lakefile to point to leanprover-community/batteries:main - [x] Run lake update batteries - [ ] Wait for CI and merge Co-authored-by: mathlib-nightly-testing[bot] <mathlib-nightly-testing[bot]@users.noreply.github.com> Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
Maldooor
pushed a commit
to Maldooor/mathlib4
that referenced
this pull request
Feb 25, 2026
After [batteries#1663](leanprover-community/batteries#1663) is merged: - [x] Merge leanprover-community/mathlib4:master - [x] Edit the lakefile to point to leanprover-community/batteries:main - [x] Run lake update batteries - [ ] Wait for CI and merge Co-authored-by: mathlib-nightly-testing[bot] <mathlib-nightly-testing[bot]@users.noreply.github.com> Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
fgdorais
added a commit
that referenced
this pull request
Feb 26, 2026
Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Mar 2, 2026
After [batteries#1663](leanprover-community/batteries#1663) is merged: - [x] Merge leanprover-community/mathlib4:master - [x] Edit the lakefile to point to leanprover-community/batteries:main - [x] Run lake update batteries - [ ] Wait for CI and merge Co-authored-by: mathlib-nightly-testing[bot] <mathlib-nightly-testing[bot]@users.noreply.github.com> Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes style improvements and corrects deprecation comments.
In #1421, style comments were not addressed before merge. In particular, an old name for a function used in a deprecation comment was not updated. This PR fixes #1628, actions the other missed style comments from #1421, and makes some other improvements for ergonomic reasons.
An adaption PR for Mathlib will be needed as IsChain.of_cons is now replicated downstream.
Closes #1628