perf: run linters only on public imports#1688
Open
JovanGerb wants to merge 4 commits intoleanprover-community:mainfrom
Open
perf: run linters only on public imports#1688JovanGerb wants to merge 4 commits intoleanprover-community:mainfrom
JovanGerb wants to merge 4 commits intoleanprover-community:mainfrom
Conversation
github-actions
bot
added
the
awaiting-review
mathlib-nightly-testing bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Feb 21, 2026
mathlib-nightly-testing bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Feb 21, 2026
JovanGerb
commented
Feb 21, 2026
| | .axiomInfo .. => pure "axiom" | ||
| | .opaqueInfo .. => pure "constant" | ||
| | .defnInfo info => | ||
| -- leanprover/lean4#2575: Prop projections are generated as `def`s |
Contributor
Author
There was a problem hiding this comment.
This lean issue has been resolved in the meantime
Contributor
Author
|
The mathlib branch doesn't build, because there are various instances of private declarations appearning in the public scope (which is not meant to be allowed). So this PR will have to wait. |
fgdorais
added
breaks-mathlib
awaiting-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets the
runLintercommand participate in the module system. In particular, linters now only run on exported data. We need to have access to doc-strings for the docBlame linter, so we have to use the.serverlevel of imports instead of.exported.The docBlame linter had to be fixed, because it was detecting imported theorems as axioms.
Is there any linter that requires access to private information from modules?