fix: update defLemma and related linters correctly#1727
Open
thorimur wants to merge 8 commits intoleanprover-community:mainfrom
Open
fix: update defLemma and related linters correctly#1727thorimur wants to merge 8 commits intoleanprover-community:mainfrom
defLemma and related linters correctly#1727thorimur wants to merge 8 commits intoleanprover-community:mainfrom
Conversation
github-actions
bot
added
the
awaiting-review
mathlib-nightly-testing bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 20, 2026
mathlib-nightly-testing bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 20, 2026
Rob23oba
reviewed
Mar 20, 2026
mathlib-nightly-testing bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 20, 2026
mathlib-nightly-testing bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 6, 2026
3 tasks
mathlib-nightly-testing bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 7, 2026
Contributor
Author
|
Hmm, this builds mathlib after including a workaround, but maybe we should instead just wait for leanprover/lean4#13304 to land and percolate through, which fixes the issue I'm working around? Not sure how long that would be. EDIT: Ok, great, Kim has fixed it, so I suppose let's just wait :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
defLemmalinter wrongly ignored@[implicit_reducible]defs due to an incorrect adaptation when bumping lean versions. ZulipHowever, instances created through the delta-deriving handler do not properly get registered as
theorems (leanprover/lean4#13295) and are instead alwaysdefs. We ignore definitions satisfying bothisInstanceandisImplicitReducibleas a workaround.We also take this chance to (1) note that leanprover/lean4#2575 has been fixed, allowing us to remove some workarounds in
defLemmaand other linters (2) clean up the code slightly.