feat: helpers to log on declaration names#1734
Open
thorimur wants to merge 4 commits intoleanprover-community:mainfrom
Open
feat: helpers to log on declaration names#1734thorimur wants to merge 4 commits intoleanprover-community:mainfrom
thorimur wants to merge 4 commits intoleanprover-community:mainfrom
Conversation
github-actions
bot
added
the
awaiting-review
mathlib-nightly-testing bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bridges the gap between the declaration ranges stored in the
DeclarationRangeextension (used for e.g. go-to-def) andSyntaxposition info that can be used to log messages interactively.Specifically, it introduces
DeclarationRange.toSyntaxRange,findDeclarationSyntaxRange?, andwithDeclRef?. The latter two ensure that the constant is not imported before constructing position info.