fix: move set_option inside @[expose] public section in Lemmas#1746
Closed
fix: move set_option inside @[expose] public section in Lemmas#1746
Conversation
Co-authored-by: mathlib4-bot <github-mathlib4-bot@leanprover.zulipchat.com> Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Kim Morrison <kim@tqft.net> Co-authored-by: leanprover-community-mathlib4-bot <129911861+leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Markus Himmel <markus@lean-fro.org> Co-authored-by: Kim Morrison <477956+kim-em@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Eric Wieser <efw@google.com> Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch> Co-authored-by: Kyle Miller <kmill31415@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Matthew Ballard <matt@mrb.email> Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Joachim Breitner <mail@joachim-breitner.de> Co-authored-by: Mac Malone <mac@lean-fro.org> Co-authored-by: Rob23oba <152706811+Rob23oba@users.noreply.github.com> Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Paul Reichert <6992158+datokrat@users.noreply.github.com> Co-authored-by: Parth Shastri <31370288+cppio@users.noreply.github.com> Co-authored-by: Joseph Rotella <7482866+jrr6@users.noreply.github.com> Co-authored-by: François G. Dorais <fgdorais@gmail.com> Co-authored-by: Marc Huisinga <mhuisi@protonmail.com> Co-authored-by: Sebastian Graf <sgraf1337@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: mathlib-nightly-testing[bot] <mathlib-nightly-testing[bot]@users.noreply.github.com>
Co-authored-by: mathlib4-bot <github-mathlib4-bot@leanprover.zulipchat.com> Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Kim Morrison <kim@tqft.net> Co-authored-by: leanprover-community-mathlib4-bot <129911861+leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Markus Himmel <markus@lean-fro.org> Co-authored-by: Kim Morrison <477956+kim-em@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Eric Wieser <efw@google.com> Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch> Co-authored-by: Kyle Miller <kmill31415@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Matthew Ballard <matt@mrb.email> Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Joachim Breitner <mail@joachim-breitner.de> Co-authored-by: Mac Malone <mac@lean-fro.org> Co-authored-by: Rob23oba <152706811+Rob23oba@users.noreply.github.com> Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Paul Reichert <6992158+datokrat@users.noreply.github.com> Co-authored-by: Parth Shastri <31370288+cppio@users.noreply.github.com> Co-authored-by: Joseph Rotella <7482866+jrr6@users.noreply.github.com> Co-authored-by: François G. Dorais <fgdorais@gmail.com> Co-authored-by: Marc Huisinga <mhuisi@protonmail.com> Co-authored-by: Sebastian Graf <sgraf1337@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: mathlib-nightly-testing[bot] <mathlib-nightly-testing[bot]@users.noreply.github.com>
Adapt to upstream changes from lean4#13091 (verify `String.join`) and lean4#13106 (lemmas about `String.Pos.nextn`). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Kim Morrison <kim@tqft.net> Co-authored-by: mathlib4-bot <github-mathlib4-bot@leanprover.zulipchat.com> Co-authored-by: mathlib-nightly-testing[bot] <mathlib-nightly-testing[bot]@users.noreply.github.com> Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: mathlib-nightly-testing[bot] <258991302+mathlib-nightly-testing[bot]@users.noreply.github.com> Co-authored-by: Paul Reichert <6992158+datokrat@users.noreply.github.com> Co-authored-by: leanprover-community-mathlib4-bot <129911861+leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Markus Himmel <markus@lean-fro.org> Co-authored-by: Kim Morrison <477956+kim-em@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Eric Wieser <efw@google.com> Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch> Co-authored-by: Kyle Miller <kmill31415@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Matthew Ballard <matt@mrb.email> Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Joachim Breitner <mail@joachim-breitner.de> Co-authored-by: Mac Malone <mac@lean-fro.org> Co-authored-by: Rob23oba <152706811+Rob23oba@users.noreply.github.com> Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Parth Shastri <31370288+cppio@users.noreply.github.com> Co-authored-by: Joseph Rotella <7482866+jrr6@users.noreply.github.com> Co-authored-by: François G. Dorais <fgdorais@gmail.com> Co-authored-by: Marc Huisinga <mhuisi@protonmail.com> Co-authored-by: Sebastian Graf <sgraf1337@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…ic section` `set_option ... in @[expose] public section` causes the section's declarations to not be exported via normal `import`. Moving the `set_option` inside the section fixes this. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
the
awaiting-review
Collaborator
Author
|
Closing - PR had extraneous commits from wrong base. Will recreate cleanly. |
github-actions
bot
removed
the
awaiting-review
mathlib-nightly-testing bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
set_option linter.deprecated falsefrom before@[expose] public sectionto inside it inBatteries/Data/String/Lemmas.lean.The
set_option ... in @[expose] public sectionpattern (introduced in #1736) causes the section's declarations to not be exported via normalimport, making constants likeutf8Len_cons,rawEndPos_ofList, andhasNext_cons_addCharinvisible to downstream consumers.🤖 Prepared with Claude Code