feat: add set algebra support#188
Open
Kaptch wants to merge 12 commits intoleanprover-community:masterfrom
Open
feat: add set algebra support#188Kaptch wants to merge 12 commits intoleanprover-community:masterfrom
Kaptch wants to merge 12 commits intoleanprover-community:masterfrom
Conversation
Collaborator
markusdemedeiros
left a comment
There was a problem hiding this comment.
Hey! Great work on this PR, it's a very nice solution.
I left a lot of refactoring comments, many of them apply multiple times. If you want, I can do a cleanup pass on this PR, but I figured I'd give them to you first if you wanted to try. Let me know what you want to do.
Contributor
Author
|
Hi! Thank you for the review! |
Collaborator
|
Thanks for the updates, I'll do my best to give it another look soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds set and finite sets interfaces to Std, set algebra and bigOpS. There's an example of usage in Examples/Namesets. Set algebra should work for LawfulSet (not necessarily finite) with decidable disjointedness.
This is still wip.
Before it can be finished, I will do two things:
Checklist
PORTING.mdas appropriateauthorssection of any appropriate files