Skip to content

[Merged by Bors] - fix(CI): remove labels on bors merge-#21645

Closed
adomani wants to merge 5 commits intomasterfrom
adomani/also_merge_removes_labels
Closed

[Merged by Bors] - fix(CI): remove labels on bors merge-#21645
adomani wants to merge 5 commits intomasterfrom
adomani/also_merge_removes_labels

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Feb 10, 2025

Reported on

#21636

This makes the older regex be more restrictive, since it now should distinguish between bors d+/bors delegate on one hand and bors d- on the other.

Also fixes a bug in the previous PR: I had forgotten to "close" the sed call.


Open in Gitpod

@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Feb 10, 2025

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 10, 2025

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 10, 2025
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Feb 10, 2025

bors d-

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 10, 2025

PR summary f18f4624fe

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Feb 10, 2025
@adomani adomani added WIP Work in progress awaiting-author A reviewer has asked the author a question or requested changes. labels Feb 10, 2025
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Feb 10, 2025

bors d-

@ghost ghost removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 10, 2025
@adomani adomani removed WIP Work in progress delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). labels Feb 10, 2025
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Feb 10, 2025

bors r-

Sorry, I noticed a mistake in the sed formatting: I am using = as a sed separator and cannot use it in the match, unless I escape it!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 10, 2025

Canceled.

@bryangingechen
Copy link
Copy Markdown
Contributor

OK, feel free to put it back on the queue when ready!
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 10, 2025

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 10, 2025
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Feb 10, 2025

bors merge

Let's try this!

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 10, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 10, 2025
Reported on

#21636

This makes the older regex be more restrictive, since it now should distinguish between `bors d+`/`bors delegate` on one hand and `bors d-` on the other.

Also fixes a bug in the previous PR: I had forgotten to "close" the `sed` call.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 10, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(CI): remove labels on bors merge- [Merged by Bors] - fix(CI): remove labels on bors merge- Feb 10, 2025
@mathlib-bors mathlib-bors bot closed this Feb 10, 2025
@mathlib-bors mathlib-bors bot deleted the adomani/also_merge_removes_labels branch February 10, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants