Skip to content

[Merged by Bors] - fix(bors d-): make CI continue with bors d-#21676

Closed
adomani wants to merge 1 commit intomasterfrom
adomani/bors_d_minus_again
Closed

[Merged by Bors] - fix(bors d-): make CI continue with bors d-#21676
adomani wants to merge 1 commit intomasterfrom
adomani/bors_d_minus_again

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Feb 10, 2025

In the previous PRs, I forgot to make the tests verify that the new variable was set. As a consequence, the action never really worked with bors d-, since passing the tests was required for the later steps.


The bug was exposed in

Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary 5723dbc7f7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Feb 10, 2025
Copy link
Copy Markdown
Contributor

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Feb 11, 2025
mathlib-bors bot pushed a commit that referenced this pull request Feb 11, 2025
In the previous PRs, I forgot to make the tests verify that the new variable was set.  As a consequence, the action never really worked with `bors d-`, since passing the tests was required for the later steps.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 11, 2025

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 11, 2025
In the previous PRs, I forgot to make the tests verify that the new variable was set.  As a consequence, the action never really worked with `bors d-`, since passing the tests was required for the later steps.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(bors d-): make CI continue with bors d- [Merged by Bors] - fix(bors d-): make CI continue with bors d- Feb 11, 2025
@mathlib-bors mathlib-bors bot closed this Feb 11, 2025
@mathlib-bors mathlib-bors bot deleted the adomani/bors_d_minus_again branch February 11, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants