Skip to content

feat: Refactor and add some easy lemmas about Galois theory#22759

Closed
yhtq wants to merge 18 commits intomasterfrom
GuoZiXun/minpoly
Closed

feat: Refactor and add some easy lemmas about Galois theory#22759
yhtq wants to merge 18 commits intomasterfrom
GuoZiXun/minpoly

Conversation

@yhtq
Copy link
Copy Markdown
Collaborator

@yhtq yhtq commented Mar 10, 2025

Move fixingSubgroup_top/bot back to Galois.basic, add fixedField_top/bot,mem_bot_iff_fixed and mem_range_algebraMap_iff_fixed


Open in Gitpod

@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc) labels Mar 10, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2025

PR summary 324a7e0be1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ fixedField_bot
+ fixedField_top
+ fixingSubgroup_bot
+ fixingSubgroup_top
+ mem_bot_iff_fixed
+ mem_fixingSubgroup_iff
+ mem_range_algebraMap_iff_fixed
- IntermediateField.fixingSubgroup_bot
- IntermediateField.fixingSubgroup_top
- IntermediateField.mem_fixingSubgroup_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

yhtq and others added 7 commits March 12, 2025 09:23
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
@tb65536
Copy link
Copy Markdown
Contributor

tb65536 commented Mar 16, 2025

Note that this PR overlaps with #22971

@yhtq yhtq requested review from Thmoas-Guan and adomani March 17, 2025 10:57
@Thmoas-Guan
Copy link
Copy Markdown
Collaborator

Thmoas-Guan commented Mar 17, 2025

@yhtq @mbkybky shall we are combining this one with #22971? So we are merging that one into this PR and close #22971,right?

exact le_trans h ((le_iff_le _ _).mpr (le_refl K'.fixingSubgroup))

@[simp] lemma mem_fixingSubgroup_iff (σ) : σ ∈ fixingSubgroup K ↔ ∀ x ∈ K, σ x = x :=
_root_.mem_fixingSubgroup_iff _
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether the _root_ here is an indication that the namespaced mem_fixingSubgroup_iff should be protected instead.

@yhtq
Copy link
Copy Markdown
Collaborator Author

yhtq commented Mar 17, 2025

@yhtq @mbkybky shall we are combining this one with #22971? So we are merging that one into this PR and close #22971,right?

I think #22971 makes a little more changes than me. So perhaps merging this PR into that one and close this one?

@mbkybky
Copy link
Copy Markdown
Collaborator

mbkybky commented Mar 18, 2025

I think #22971 makes a little more changes than me. So perhaps merging this PR into that one and close this one?

Ok, I think it's fine.

@yhtq yhtq closed this Mar 18, 2025
@YaelDillies YaelDillies deleted the GuoZiXun/minpoly branch August 15, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants