Skip to content

[Merged by Bors] - feat(Algebra/AlgHom): Unique if target is Subsingleton#24379

Closed
chrisflav wants to merge 3 commits intomasterfrom
chrisflav-alghominhab
Closed

[Merged by Bors] - feat(Algebra/AlgHom): Unique if target is Subsingleton#24379
chrisflav wants to merge 3 commits intomasterfrom
chrisflav-alghominhab

Conversation

@chrisflav
Copy link
Copy Markdown
Member


Open in Gitpod

@chrisflav chrisflav added the t-algebra Algebra (groups, rings, fields, etc) label Apr 26, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 26, 2025

PR summary e6edd78610

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ AlgEquiv.default_apply
+ AlgHom.default_apply
+ instance [Subsingleton S] [Subsingleton T] : Unique (S ≃ₐ[R] T)
+ uniqueOfRight

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@eric-wieser eric-wieser added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 26, 2025
Co-authored-by: Eric Wieser <efw@google.com>
@chrisflav chrisflav removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 1, 2025
@chrisflav
Copy link
Copy Markdown
Member Author

Any further comments @eric-wieser?

Copy link
Copy Markdown
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been stale for months now. The comment was not resolved but I think Christian's reply is reasonable, and I don't think this should go in Subalgebra.Lattice.

maintainer merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 5, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@erdOne
Copy link
Copy Markdown
Member

erdOne commented Jul 5, 2025

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 5, 2025

🚀 Pull request has been placed on the maintainer queue by erdOne.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 5, 2025
@erdOne
Copy link
Copy Markdown
Member

erdOne commented Jul 5, 2025

(why did my previous invocation not work?)

@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 5, 2025

✌️ chrisflav can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jul 5, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 20, 2025
@chrisflav
Copy link
Copy Markdown
Member Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 21, 2025
Co-authored-by: Christian Merten <136261474+chrisflav@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 21, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/AlgHom): Unique if target is Subsingleton [Merged by Bors] - feat(Algebra/AlgHom): Unique if target is Subsingleton Jul 21, 2025
@mathlib-bors mathlib-bors bot closed this Jul 21, 2025
@mathlib-bors mathlib-bors bot deleted the chrisflav-alghominhab branch July 21, 2025 05:26
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
…r-community#24379)

Co-authored-by: Christian Merten <136261474+chrisflav@users.noreply.github.com>
hrmacbeth pushed a commit to szqzs/mathlib4 that referenced this pull request Jul 28, 2025
…r-community#24379)

Co-authored-by: Christian Merten <136261474+chrisflav@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants