Skip to content

[Merged by Bors] - chore(RingTheory/TensorProduct): more product compatibilities#24380

Closed
chrisflav wants to merge 2 commits intomasterfrom
chrisflav-algequiv-prod
Closed

[Merged by Bors] - chore(RingTheory/TensorProduct): more product compatibilities#24380
chrisflav wants to merge 2 commits intomasterfrom
chrisflav-algequiv-prod

Conversation

@chrisflav
Copy link
Copy Markdown
Member


Open in Gitpod

@chrisflav chrisflav added the t-algebra Algebra (groups, rings, fields, etc) label Apr 26, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 26, 2025

PR summary 0403590095

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.TensorProduct.Pi 979 980 +1 (+0.10%)
Import changes for all files
Files Import difference
Mathlib.Algebra.Category.Ring.Under.Limits Mathlib.RingTheory.TensorProduct.Pi 1

Declarations diff

+ piRight
+ piRight_tmul
+ piScalarRight
+ piScalarRight_tmul
+ piScalarRight_tmul_apply
+ prodRight
+ prodRight_symm_tmul
+ prodRight_tmul
+ prodRight_tmul_fst
+ prodRight_tmul_snd
- Algebra.TensorProduct.piRight
- Algebra.TensorProduct.piRight_tmul

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 27, 2025
@chrisflav chrisflav added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels May 1, 2025
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label May 1, 2025
@erdOne
Copy link
Copy Markdown
Member

erdOne commented May 30, 2025

Thanks
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by erdOne.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 30, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 3, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 3, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(RingTheory/TensorProduct): more product compatibilities [Merged by Bors] - chore(RingTheory/TensorProduct): more product compatibilities Jun 3, 2025
@mathlib-bors mathlib-bors bot closed this Jun 3, 2025
@mathlib-bors mathlib-bors bot deleted the chrisflav-algequiv-prod branch June 3, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants