Skip to content

[Merged by Bors] - feat(CategoryTheory): pseudofunctors from strict bicategories#24382

Closed
joelriou wants to merge 14 commits intomasterfrom
pseudofunctor-mapcomp-prime
Closed

[Merged by Bors] - feat(CategoryTheory): pseudofunctors from strict bicategories#24382
joelriou wants to merge 14 commits intomasterfrom
pseudofunctor-mapcomp-prime

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

This PR provides an API for pseudofunctors F from a strict bicategory B. In particular, this shall apply to pseudofunctors from locally discrete bicategories.

We first introduce more flexible variants of mapId and mapComp: for example, if f and g are composable morphisms and fg is such that h : fg = f ≫ f, we provide an isomorphism F.mapComp' f g fg h : F.map fg ≅ F.map f ≫ F.map g. We study the compatibilities of these isomorphisms with respect to composition with identities and associativity.

Secondly, given a commutative square t ≫ r = l ≫ b in B, we construct an isomorphism F.map t ≫ F.map r ≅ F.map l ≫ F.map b.

Co-authored-by: Christian Merten christian@merten.dev


Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Apr 26, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 26, 2025

PR summary a4ec7db301

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Bicategory.Functor.Strict (new file) 360

Declarations diff

+ isoMapOfCommSq
+ isoMapOfCommSq_eq
+ isoMapOfCommSq_horiz_id
+ isoMapOfCommSq_vert_id
+ mapComp'
+ mapComp'_comp_id
+ mapComp'_eq_mapComp
+ mapComp'_hom_comp_mapComp'_hom_whiskerRight
+ mapComp'_hom_comp_whiskerLeft_mapComp'_hom
+ mapComp'_id_comp
+ mapComp'_inv_comp_mapComp'_hom
+ mapComp'_inv_whiskerRight_comp_mapComp'_inv
+ mapId'
+ mapId'_eq_mapId
+ whiskerLeft_mapComp'_inv_comp_mapComp'_inv

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou joelriou added the WIP Work in progress label Apr 26, 2025
@joelriou joelriou removed the WIP Work in progress label Apr 26, 2025
@joelriou joelriou added the WIP Work in progress label Apr 26, 2025
@joelriou joelriou removed the WIP Work in progress label Apr 26, 2025
@erdOne erdOne requested a review from callesonne April 27, 2025 11:52
Copy link
Copy Markdown
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think .hom and .inv simp lemmas are useful here?

joelriou and others added 2 commits May 1, 2025 16:52
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label May 1, 2025
@joelriou
Copy link
Copy Markdown
Contributor Author

joelriou commented May 1, 2025

Do you think .hom and .inv simp lemmas are useful here?

If the remark applies to mapComp'_comp_id and mapComp'_id_comp, I do not think we need _hom/_inv versions, as it seems very unlikely that we would need to apply these lemmas in the backwards direction. The situation is different for the associativity lemmas because they relate four different mapComp' isomorphisms.

@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 1, 2025
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label May 11, 2025
joelriou and others added 2 commits May 11, 2025 12:07
Co-authored-by: Calle Sönne <calle.sonne@gmail.com>
Co-authored-by: Calle Sönne <calle.sonne@gmail.com>
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 11, 2025
@joelriou
Copy link
Copy Markdown
Contributor Author

Thanks @callesonne and @erdOne for the reviews!

@callesonne callesonne added the awaiting-author A reviewer has asked the author a question or requested changes. label May 11, 2025
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 11, 2025
Copy link
Copy Markdown
Collaborator

@callesonne callesonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@callesonne
Copy link
Copy Markdown
Collaborator

@erdOne do you want to maintainer merge this?

Copy link
Copy Markdown
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 7, 2025

🚀 Pull request has been placed on the maintainer queue by erdOne.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 7, 2025
@jcommelin
Copy link
Copy Markdown
Member

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jun 16, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jun 16, 2025
This PR provides an API for pseudofunctors `F` from a strict bicategory `B`. In particular, this shall apply to pseudofunctors from locally discrete bicategories.

We first introduce more flexible variants of `mapId` and `mapComp`: for example, if `f` and `g` are composable morphisms and `fg` is such that `h : fg = f ≫ f`, we provide an isomorphism `F.mapComp' f g fg h : F.map fg ≅ F.map f ≫ F.map g`. We study the compatibilities of these isomorphisms with respect to composition with identities and associativity.

Secondly, given a commutative square `t ≫ r = l ≫ b` in `B`, we construct an isomorphism `F.map t ≫ F.map r ≅ F.map l ≫ F.map b`.

Co-authored-by: Christian Merten <christian@merten.dev>



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 16, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory): pseudofunctors from strict bicategories [Merged by Bors] - feat(CategoryTheory): pseudofunctors from strict bicategories Jun 16, 2025
@mathlib-bors mathlib-bors bot closed this Jun 16, 2025
@mathlib-bors mathlib-bors bot deleted the pseudofunctor-mapcomp-prime branch June 16, 2025 07:16
Rida-Hamadani pushed a commit to Rida-Hamadani/mathlib4 that referenced this pull request Jun 24, 2025
…over-community#24382)

This PR provides an API for pseudofunctors `F` from a strict bicategory `B`. In particular, this shall apply to pseudofunctors from locally discrete bicategories.

We first introduce more flexible variants of `mapId` and `mapComp`: for example, if `f` and `g` are composable morphisms and `fg` is such that `h : fg = f ≫ f`, we provide an isomorphism `F.mapComp' f g fg h : F.map fg ≅ F.map f ≫ F.map g`. We study the compatibilities of these isomorphisms with respect to composition with identities and associativity.

Secondly, given a commutative square `t ≫ r = l ≫ b` in `B`, we construct an isomorphism `F.map t ≫ F.map r ≅ F.map l ≫ F.map b`.

Co-authored-by: Christian Merten <christian@merten.dev>



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
callesonne pushed a commit to callesonne/mathlib4 that referenced this pull request Jul 24, 2025
…over-community#24382)

This PR provides an API for pseudofunctors `F` from a strict bicategory `B`. In particular, this shall apply to pseudofunctors from locally discrete bicategories.

We first introduce more flexible variants of `mapId` and `mapComp`: for example, if `f` and `g` are composable morphisms and `fg` is such that `h : fg = f ≫ f`, we provide an isomorphism `F.mapComp' f g fg h : F.map fg ≅ F.map f ≫ F.map g`. We study the compatibilities of these isomorphisms with respect to composition with identities and associativity.

Secondly, given a commutative square `t ≫ r = l ≫ b` in `B`, we construct an isomorphism `F.map t ≫ F.map r ≅ F.map l ≫ F.map b`.

Co-authored-by: Christian Merten <christian@merten.dev>



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants