[Merged by Bors] - chore(Order): process misc porting notes#24431
Closed
[Merged by Bors] - chore(Order): process misc porting notes#24431
Conversation
Member
jcommelin
commented
Apr 28, 2025
jcommelin
commented
PR summary 8d76e795a9Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for Decrease in tech debt: (relative, absolute) = (10.00, 0.01)
Current commit 8d76e795a9 You can run this locally as
|
grunweg
reviewed
May 1, 2025
Contributor
grunweg
left a comment
grunweg
left a comment
There was a problem hiding this comment.
Thanks!
maintainer delegate
|
|
||
| theorem map_div_atTop_eq_nat (k : ℕ) (hk : 0 < k) : map (fun a => a / k) atTop = atTop := | ||
| map_atTop_eq_of_gc (fun b => k * b + (k - 1)) 1 (fun _ _ h => Nat.div_le_div_right h) | ||
| -- Porting note: there was a parse error in `calc`, use `simp` instead |
Contributor
There was a problem hiding this comment.
Flagging this change for a second opinion
Contributor
There was a problem hiding this comment.
The porting note seems to be outdated since the simp was removed in #16611.
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
github-actions
bot
added
the
maintainer-merge
ghost
added
ready-to-merge
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
riccardobrasca
pushed a commit
that referenced
this pull request
May 7, 2025
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.