Skip to content

[Merged by Bors] - feat: add supporting API for Geck's final root system lemma#24476

Closed
ocfnash wants to merge 9 commits intomasterfrom
ocfnash/geck_2_6_support
Closed

[Merged by Bors] - feat: add supporting API for Geck's final root system lemma#24476
ocfnash wants to merge 9 commits intomasterfrom
ocfnash/geck_2_6_support

Conversation

@ocfnash
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash commented Apr 30, 2025

Most of this API is to support a proof of Lemma 2.6 from Geck which will be added in a follow-up PR. However these results all make sense in their own right.


Open in Gitpod

Most of this API is to support a proof of Lemma 2.6 from [Geck](Geck2017)
which will be added in a follow-up PR. However these results all make
sense in their own right.
@ocfnash ocfnash added WIP Work in progress t-algebra Algebra (groups, rings, fields, etc) labels Apr 30, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 30, 2025

PR summary ee6545aa58

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.LinearAlgebra.RootSystem.Chain 1510 1511 +1 (+0.07%)
Import changes for all files
Files Import difference
Mathlib.LinearAlgebra.RootSystem.Chain 1

Declarations diff

+ IsG2
+ IsG2.pairingIn_mem_zero_one_three
+ IsNotG2
+ RootPositiveForm.rootLength_le_of_pairingIn_eq
+ RootPositiveForm.rootLength_lt_of_pairingIn_nmem
+ algebraMap_rootLength
+ chainBotCoeff_add_chainTopCoeff_eq_pairingIn_chainTopIdx
+ chainBotCoeff_add_chainTopCoeff_le_three
+ chainBotCoeff_add_chainTopCoeff_le_two
+ chainBotCoeff_of_not_linearIndependent
+ chainBotCoeff_reflection_perm_left
+ chainBotCoeff_reflection_perm_right
+ chainTopCoeff_of_not_linearIndependent
+ chainTopCoeff_reflection_perm_left
+ chainTopCoeff_reflection_perm_right
+ corootSpanMem_reflection_perm_self
+ forall_pairingIn_eq_swap_or
+ forall_pairing_eq_swap_or
+ infinite_of_linearIndependent_coxeterWeight_four
+ instance [P.IsIrreducible] : P.IsG2
+ isG2_iff
+ isNotG2_iff
+ linearIndependent_of_add_mem_range_root
+ linearIndependent_of_sub_mem_range_root
+ not_isG2_iff_isNotG2
+ pairingIn_eq_zero_iff
+ pairingIn_le_zero_iff
+ pairingIn_lt_zero_iff
+ pairingIn_mul_eq_pairingIn_mul_swap
+ pairing_eq_zero_iff
+ pairing_eq_zero_iff'
+ pairing_smul_root_eq_of_not_linearIndependent
+ rootLength
+ rootLength_pos
+ rootLength_reflection_perm_self
+ rootSpanMem_reflection_perm_self
+ root_ne_neg_of_ne
+ setOf_root_add_zsmul_eq_Icc_of_linearIndependent
+ two_smul_nmem_range_root
+ zero_nmem_range_coroot
+ zero_nmem_range_root
- chainBotCoeff_add_chainTopCoeff_le
- chainBotCoeff_of_not_linInd
- chainBotCoeff_relfection_perm
- chainTopCoeff_of_not_linInd
- chainTopCoeff_relfection_perm
- infinite_of_linInd_coxeterWeight_four
- pairingIn_zero_iff
- pairing_smul_root_eq_of_not_linInd
- pairing_zero_iff
- pairing_zero_iff'
- setOf_root_add_zsmul_eq_Icc_of_linInd

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 30, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 30, 2025
@ocfnash ocfnash removed the WIP Work in progress label May 1, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo a typo

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 1, 2025

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label May 1, 2025
@ocfnash
Copy link
Copy Markdown
Contributor Author

ocfnash commented May 1, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label May 1, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 1, 2025
Most of this API is to support a proof of Lemma 2.6 from [Geck](Geck2017) which will be added in a follow-up PR. However these results all make sense in their own right.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 1, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add supporting API for Geck's final root system lemma [Merged by Bors] - feat: add supporting API for Geck's final root system lemma May 1, 2025
@mathlib-bors mathlib-bors bot closed this May 1, 2025
@mathlib-bors mathlib-bors bot deleted the ocfnash/geck_2_6_support branch May 1, 2025 22:10
pfaffelh pushed a commit that referenced this pull request May 2, 2025
Most of this API is to support a proof of Lemma 2.6 from [Geck](Geck2017) which will be added in a follow-up PR. However these results all make sense in their own right.
riccardobrasca pushed a commit that referenced this pull request May 7, 2025
Most of this API is to support a proof of Lemma 2.6 from [Geck](Geck2017) which will be added in a follow-up PR. However these results all make sense in their own right.
tannerduve pushed a commit that referenced this pull request May 13, 2025
Most of this API is to support a proof of Lemma 2.6 from [Geck](Geck2017) which will be added in a follow-up PR. However these results all make sense in their own right.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants