Skip to content

refactor (RingTheory/HahnSeries/HEval): remove positive order condition from definition#24498

Closed
ScottCarnahan wants to merge 5 commits intomasterfrom
ScottCarnahan/HEvalLemmas
Closed

refactor (RingTheory/HahnSeries/HEval): remove positive order condition from definition#24498
ScottCarnahan wants to merge 5 commits intomasterfrom
ScottCarnahan/HEvalLemmas

Conversation

@ScottCarnahan
Copy link
Copy Markdown
Collaborator

@ScottCarnahan ScottCarnahan commented May 1, 2025

This PR removes the positive order condition for substitution (or Hahn evaluation) of a Hahn series into a power series. When the order is not positive, the function substitutes zero. We also add short lemmas for substitution into PowerSeries.X and PowerSeries.C.


Is there a better way to express eq_toFun?

Open in Gitpod

@ScottCarnahan ScottCarnahan added the t-algebra Algebra (groups, rings, fields, etc) label May 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 1, 2025

PR summary 7deb334c5f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ heval_C
+ heval_X

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@ScottCarnahan ScottCarnahan changed the title feat (RingTheory/HahnSeries/HEval): two HEval lemmas refactor (RingTheory/HahnSeries/HEval): remove positive order condition from definition May 11, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 7, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 9, 2025
@ScottCarnahan
Copy link
Copy Markdown
Collaborator Author

This PR has been migrated to a fork-based workflow: #25830

@YaelDillies YaelDillies deleted the ScottCarnahan/HEvalLemmas branch August 15, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants