Skip to content

[Merged by Bors] - chore: whitespace still#24501

Closed
adomani wants to merge 6 commits intomasterfrom
whitespace/further_changes
Closed

[Merged by Bors] - chore: whitespace still#24501
adomani wants to merge 6 commits intomasterfrom
whitespace/further_changes

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented May 1, 2025

Mostly whitespace changes found by the linter at #24465.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 1, 2025

PR summary 5beb7f436d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

/-- In a category with pullbacks, a morphism `f : X ⟶ Y` induces a functor `Over Y ⥤ Over X`,
by pulling back a morphism along `f`. -/
@[simps! (config := { simpRhs := true}) obj_left obj_hom map_left]
@[simps! +simpRhs obj_left obj_hom map_left]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also part of #24502; these PRs could land in either order.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks: I delegated the other PR.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 1, 2025

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 1, 2025
@urkud
Copy link
Copy Markdown
Member

urkud commented May 1, 2025

Thanks!
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 1, 2025

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 1, 2025
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented May 1, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label May 1, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 1, 2025
Mostly whitespace changes found by the linter at #24465.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 1, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: whitespace still [Merged by Bors] - chore: whitespace still May 1, 2025
@mathlib-bors mathlib-bors bot closed this May 1, 2025
@mathlib-bors mathlib-bors bot deleted the whitespace/further_changes branch May 1, 2025 12:40
riccardobrasca pushed a commit that referenced this pull request May 7, 2025
Mostly whitespace changes found by the linter at #24465.
tannerduve pushed a commit that referenced this pull request May 13, 2025
Mostly whitespace changes found by the linter at #24465.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants