[Merged by Bors] - refactor(Geometry/Euclidean): use orthogonalProjectionSpan more#24503
[Merged by Bors] - refactor(Geometry/Euclidean): use orthogonalProjectionSpan more#24503
orthogonalProjectionSpan more#24503Conversation
Make more use of `orthogonalProjectionSpan` in `Mathlib.Geometry.Euclidean.Projection` and `Mathlib.Geometry.Euclidean.SignedDist`. Split out from #23752.
PR summary 3d041b4c90Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
| @@ -567,16 +567,14 @@ theorem dist_sq_eq_dist_orthogonalProjection_sq_add_dist_orthogonalProjection_sq | |||
| variable {n : ℕ} [NeZero n] (s : Simplex ℝ P n) | |||
|
|
|||
| @[simp] lemma ne_orthogonalProjection_faceOpposite (i : Fin (n + 1)) : | |||
There was a problem hiding this comment.
Arguably this lemma should be renamed to use orthogonalProjectionSpan, though of course then you'll need a deprecation.
bors d+
There was a problem hiding this comment.
(though if this will be changed again to use altitude, then fine to leave as is for now)
There was a problem hiding this comment.
Yes, I expect this to change to be about altitudeFoot (and thus move to go alongside that definition) (and I'm also doubtful of the need for deprecations for such recently added lemmas).
bors r+
|
✌️ jsm28 can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Pull request successfully merged into master. Build succeeded: |
orthogonalProjectionSpan moreorthogonalProjectionSpan more
Make more use of
orthogonalProjectionSpaninMathlib.Geometry.Euclidean.ProjectionandMathlib.Geometry.Euclidean.SignedDist. Split out from #23752.