Skip to content

[Merged by Bors] - refactor(Geometry/Euclidean): use orthogonalProjectionSpan more#24503

Closed
jsm28 wants to merge 1 commit intomasterfrom
jsm28/more_orthogonalProjectionSpan
Closed

[Merged by Bors] - refactor(Geometry/Euclidean): use orthogonalProjectionSpan more#24503
jsm28 wants to merge 1 commit intomasterfrom
jsm28/more_orthogonalProjectionSpan

Conversation

@jsm28
Copy link
Copy Markdown
Contributor

@jsm28 jsm28 commented May 1, 2025

Make more use of orthogonalProjectionSpan in
Mathlib.Geometry.Euclidean.Projection and
Mathlib.Geometry.Euclidean.SignedDist. Split out from #23752.


Open in Gitpod

Make more use of `orthogonalProjectionSpan` in
`Mathlib.Geometry.Euclidean.Projection` and
`Mathlib.Geometry.Euclidean.SignedDist`.  Split out from #23752.
@jsm28 jsm28 added the t-euclidean-geometry Affine and axiomatic geometry label May 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 1, 2025

PR summary 3d041b4c90

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@@ -567,16 +567,14 @@ theorem dist_sq_eq_dist_orthogonalProjection_sq_add_dist_orthogonalProjection_sq
variable {n : ℕ} [NeZero n] (s : Simplex ℝ P n)

@[simp] lemma ne_orthogonalProjection_faceOpposite (i : Fin (n + 1)) :
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably this lemma should be renamed to use orthogonalProjectionSpan, though of course then you'll need a deprecation.

bors d+

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(though if this will be changed again to use altitude, then fine to leave as is for now)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I expect this to change to be about altitudeFoot (and thus move to go alongside that definition) (and I'm also doubtful of the need for deprecations for such recently added lemmas).

bors r+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 1, 2025

✌️ jsm28 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label May 1, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 1, 2025
…4503)

Make more use of `orthogonalProjectionSpan` in
`Mathlib.Geometry.Euclidean.Projection` and
`Mathlib.Geometry.Euclidean.SignedDist`.  Split out from #23752.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 1, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Geometry/Euclidean): use orthogonalProjectionSpan more [Merged by Bors] - refactor(Geometry/Euclidean): use orthogonalProjectionSpan more May 1, 2025
@mathlib-bors mathlib-bors bot closed this May 1, 2025
@mathlib-bors mathlib-bors bot deleted the jsm28/more_orthogonalProjectionSpan branch May 1, 2025 14:04
riccardobrasca pushed a commit that referenced this pull request May 7, 2025
…4503)

Make more use of `orthogonalProjectionSpan` in
`Mathlib.Geometry.Euclidean.Projection` and
`Mathlib.Geometry.Euclidean.SignedDist`.  Split out from #23752.
tannerduve pushed a commit that referenced this pull request May 13, 2025
…4503)

Make more use of `orthogonalProjectionSpan` in
`Mathlib.Geometry.Euclidean.Projection` and
`Mathlib.Geometry.Euclidean.SignedDist`.  Split out from #23752.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-euclidean-geometry Affine and axiomatic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants