Skip to content

[Merged by Bors] - feat(RingTheory/Idempotents): binary version of bijective_pi_of_isIdempotentElem#24518

Closed
chrisflav wants to merge 4 commits intomasterfrom
chrisflav-idempotents
Closed

[Merged by Bors] - feat(RingTheory/Idempotents): binary version of bijective_pi_of_isIdempotentElem#24518
chrisflav wants to merge 4 commits intomasterfrom
chrisflav-idempotents

Conversation

@chrisflav
Copy link
Copy Markdown
Member

Also renames bijective_pi_of_isIdempotentElem to RingHom.pi_bijective_of_isIdempotentElem.


Open in Gitpod

@chrisflav chrisflav added the t-algebra Algebra (groups, rings, fields, etc) label May 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 1, 2025

PR summary eceb60ddc8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ AlgEquiv.prodQuotientOfIsIdempotentElem
+ RingHom.pi_bijective_of_isIdempotentElem
+ RingHom.prod_bijective_of_isIdempotentElem

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 2, 2025

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 2, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 2, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 2, 2025
…empotentElem` (#24518)

Also renames `bijective_pi_of_isIdempotentElem` to `RingHom.pi_bijective_of_isIdempotentElem`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 2, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/Idempotents): binary version of bijective_pi_of_isIdempotentElem [Merged by Bors] - feat(RingTheory/Idempotents): binary version of bijective_pi_of_isIdempotentElem May 2, 2025
@mathlib-bors mathlib-bors bot closed this May 2, 2025
@mathlib-bors mathlib-bors bot deleted the chrisflav-idempotents branch May 2, 2025 15:02
pfaffelh pushed a commit that referenced this pull request May 2, 2025
…empotentElem` (#24518)

Also renames `bijective_pi_of_isIdempotentElem` to `RingHom.pi_bijective_of_isIdempotentElem`.
riccardobrasca pushed a commit that referenced this pull request May 7, 2025
…empotentElem` (#24518)

Also renames `bijective_pi_of_isIdempotentElem` to `RingHom.pi_bijective_of_isIdempotentElem`.
tannerduve pushed a commit that referenced this pull request May 13, 2025
…empotentElem` (#24518)

Also renames `bijective_pi_of_isIdempotentElem` to `RingHom.pi_bijective_of_isIdempotentElem`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants