[Merged by Bors] - chore(NumberTheory/Cyclotomic/CyclotomicCharacter): fix name to camelCase

[acmepjz]

Fix the name of ModularCyclotomicCharacter and CyclotomicCharacter to camelCase, since they are not Type.

Also fix the module docstring.

---

[github-actions]

PR summary 0b9af5bd97

Import changes for modified files

No significant changes to the import graph

Import changes for all files

Files	Import difference

---

Declarations diff

+ CyclotomicCharacter.toFun_apply
+ CyclotomicCharacter.toFun_spec
+ CyclotomicCharacter.toZModPow_toFun
+ IsPrimitiveRoot.autToPow_eq_modularCyclotomicCharacter
+ ModularCyclotomicCharacter.comp
+ ModularCyclotomicCharacter.id
+ ModularCyclotomicCharacter.spec
+ ModularCyclotomicCharacter.toFun_spec
+ ModularCyclotomicCharacter.toFun_spec'
+ ModularCyclotomicCharacter.toFun_spec''
+ ModularCyclotomicCharacter.toFun_unique
+ ModularCyclotomicCharacter.toFun_unique'
+ ModularCyclotomicCharacter.unique
+ cyclotomicCharacter
+ cyclotomicCharacter.continuous
+ cyclotomicCharacter.spec
+ cyclotomicCharacter.toFun
+ cyclotomicCharacter.toZModPow
+ modularCyclotomicCharacter
+ modularCyclotomicCharacter'
+ modularCyclotomicCharacter'.spec'
+ modularCyclotomicCharacter'.unique'
+ modularCyclotomicCharacter.aux
+ modularCyclotomicCharacter.aux_spec
+ modularCyclotomicCharacter.pow_dvd_aux_pow_sub_aux_pow
+ modularCyclotomicCharacter.toFun

You can run this locally as follows

## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

---

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary

• The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
• The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

[grunweg]

Thanks for doing this! Can you add deprecated aliasses for the renamed definitions, please?
(scripts/add_deprecations.sh should help with that - or you can do so by hand.)

[acmepjz]

Done. Hopefully I'm doing correctly (there are several).

[Ruben-VandeVelde]

Thanks

maintainer merge

[github-actions]

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

[jcommelin]

Thanks 🎉

bors merge

[mathlib-bors]

Pull request successfully merged into master.

Build succeeded:

• Lint style
• Build