Skip to content

[Merged by Bors] - feat: restore positivity extensions for EReal#24539

Closed
Parcly-Taxel wants to merge 3 commits intomasterfrom
ereal-positivity
Closed

[Merged by Bors] - feat: restore positivity extensions for EReal#24539
Parcly-Taxel wants to merge 3 commits intomasterfrom
ereal-positivity

Conversation

@Parcly-Taxel
Copy link
Copy Markdown
Collaborator

@Parcly-Taxel Parcly-Taxel commented May 2, 2025

No description provided.

@Parcly-Taxel Parcly-Taxel added the t-data Data (lists, quotients, numbers, etc) label May 2, 2025
@Parcly-Taxel Parcly-Taxel requested a review from eric-wieser May 2, 2025 04:13
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 2, 2025

PR summary ae4f422d0b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ evalENNRealtoEReal
+ evalRealtoEReal

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
1555 -1 porting notes

Current commit ae4f422d0b
Reference commit 3703f458da

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Parcly-Taxel Parcly-Taxel requested a review from eric-wieser May 2, 2025 18:06
@eric-wieser eric-wieser added the t-meta Tactics, attributes or user commands label May 11, 2025
assertInstancesCommute
match ra with
| .positive pa => pure (.positive q(EReal.coe_ennreal_pos.2 $pa))
| .nonzero pa => pure (.nonzero q(EReal.coe_ennreal_ne_zero.2 $pa))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we know here that it's .pos and not just non-zero?

@urkud
Copy link
Copy Markdown
Member

urkud commented May 12, 2025

While you're at it, could you please add an extension for Inv.inv as well? It can only prove nonnegativity from nonnegativity. UPD: I made a branch with positivity extensions for more operations on EReal. I'm going to merge this one as is, then open a PR from my branch.

@urkud
Copy link
Copy Markdown
Member

urkud commented May 14, 2025

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label May 14, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 14, 2025
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 14, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: restore positivity extensions for EReal [Merged by Bors] - feat: restore positivity extensions for EReal May 14, 2025
@mathlib-bors mathlib-bors bot closed this May 14, 2025
@mathlib-bors mathlib-bors bot deleted the ereal-positivity branch May 14, 2025 20:17
bwehlin pushed a commit to bwehlin/mathlib4 that referenced this pull request May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc) t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants