[Merged by Bors] - feat: restore positivity extensions for EReal#24539
Closed
Parcly-Taxel wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - feat: restore positivity extensions for EReal#24539Parcly-Taxel wants to merge 3 commits intomasterfrom
EReal#24539Parcly-Taxel wants to merge 3 commits intomasterfrom
Conversation
PR summary ae4f422d0bImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current commit ae4f422d0b You can run this locally as
|
eric-wieser
reviewed
May 2, 2025
eric-wieser
reviewed
May 11, 2025
| assertInstancesCommute | ||
| match ra with | ||
| | .positive pa => pure (.positive q(EReal.coe_ennreal_pos.2 $pa)) | ||
| | .nonzero pa => pure (.nonzero q(EReal.coe_ennreal_ne_zero.2 $pa)) |
Member
There was a problem hiding this comment.
I guess we know here that it's .pos and not just non-zero?
Member
|
While you're at it, could you please add an extension for |
Member
|
bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
ERealEReal
jano-wol
pushed a commit
that referenced
this pull request
May 16, 2025
bwehlin
pushed a commit
to bwehlin/mathlib4
that referenced
this pull request
May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.