[Merged by Bors] - refactor(zulip-emoji-merge-delegate.py): consolidate repeated logic#24545
Closed
[Merged by Bors] - refactor(zulip-emoji-merge-delegate.py): consolidate repeated logic#24545
Conversation
PR summary f17197c039Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
This fixes the message for delegate emojis, to say 'delegated' and not 'peace_sign'.
cf54236 to
0d36030
Compare
Collaborator
|
This PR/issue depends on:
|
Contributor
|
Not sure from the discussion in Zulip if this is still being tested but LGTM. |
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
I would say: yes, this is being tested - but the logic change is orthogonal to this refactoring, so let's land this first. Thanks for the quick review! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 2, 2025
…24545) This script repeats the same logic for all ~5 different emojis now: extract the logic into short functions to make the code shorter.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
pfaffelh
pushed a commit
that referenced
this pull request
May 2, 2025
…24545) This script repeats the same logic for all ~5 different emojis now: extract the logic into short functions to make the code shorter.
riccardobrasca
pushed a commit
that referenced
this pull request
May 7, 2025
…24545) This script repeats the same logic for all ~5 different emojis now: extract the logic into short functions to make the code shorter.
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
…24545) This script repeats the same logic for all ~5 different emojis now: extract the logic into short functions to make the code shorter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script repeats the same logic for all ~5 different emojis now: extract the logic into short functions to make the code shorter.
Commits are best reviewed individually.