[Merged by Bors] - chore: deprime induction in AlgebraicTopology/CategoryTheory#25774
Closed
Parcly-Taxel wants to merge 16 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: deprime induction in AlgebraicTopology/CategoryTheory#25774Parcly-Taxel wants to merge 16 commits intoleanprover-community:masterfrom
induction in AlgebraicTopology/CategoryTheory#25774Parcly-Taxel wants to merge 16 commits intoleanprover-community:masterfrom
Conversation
Most replacements that are also in leanprover-community#23676 have been copied over, but some have been optimised further.
…thlib4 into deprime-algtop-cattheory
Parcly-Taxel
added
the
tech debt
PR summary de2995686cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
eric-wieser
reviewed
Jun 12, 2025
Collaborator
|
This pull request has conflicts, please merge |
leanprover-community-bot-assistant
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
madvorak
approved these changes
Jul 7, 2025
leanprover-community-bot-assistant
added
the
merge-conflict
Collaborator
|
This pull request has conflicts, please merge |
github-actions
bot
removed
the
merge-conflict
Collaborator
|
This pull request has conflicts, please merge |
leanprover-community-bot-assistant
added
the
merge-conflict
…thlib4 into deprime-algtop-cattheory
github-actions
bot
removed
the
merge-conflict
mathlib4-merge-conflict-bot
added
the
merge-conflict
Collaborator
|
This pull request has conflicts, please merge |
github-actions
bot
removed
the
merge-conflict
mathlib4-merge-conflict-bot
added
the
merge-conflict
Collaborator
|
This pull request has conflicts, please merge |
github-actions
bot
removed
the
merge-conflict
kim-em
reviewed
Sep 2, 2025
| · specialize ih (by omega) | ||
| induction h using Nat.leRec with | ||
| | refl => simp | ||
| | @le_succ_of_le m h ih => |
Contributor
There was a problem hiding this comment.
Where is leRec defined? Should we change the explicitness?
Collaborator
Author
There was a problem hiding this comment.
leRec is defined in core:
@[elab_as_elim]
def leRec {n} {motive : (m : ℕ) → n ≤ m → Sort*}
(refl : motive n (Nat.le_refl _))
(le_succ_of_le : ∀ ⦃k⦄ (h : n ≤ k), motive k h → motive (k + 1) (le_succ_of_le h)) :
∀ {m} (h : n ≤ m), motive m h
| 0, H => Nat.eq_zero_of_le_zero H ▸ refl
| m + 1, H =>
(le_succ_iff.1 H).by_cases
(fun h : n ≤ m ↦ le_succ_of_le h <| leRec refl le_succ_of_le h)
(fun h : n = m + 1 ↦ h ▸ refl)I think the strict-implicit binder ⦃k⦄ should be changed to a plain explicit binder.
Contributor
|
bors d+ |
Contributor
|
✌️ Parcly-Taxel can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
the
delegated
Collaborator
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
) Most replacements that are also in #23676 have been copied over, but some have been optimised further. Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
induction in AlgebraicTopology/CategoryTheoryinduction in AlgebraicTopology/CategoryTheory
CBirkbeck
pushed a commit
to CBirkbeck/mathlib4
that referenced
this pull request
Sep 8, 2025
…nprover-community#25774) Most replacements that are also in leanprover-community#23676 have been copied over, but some have been optimised further. Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
yuanyi-350
pushed a commit
to yuanyi-350/yuanyi_mathlib4
that referenced
this pull request
Sep 10, 2025
…nprover-community#25774) Most replacements that are also in leanprover-community#23676 have been copied over, but some have been optimised further. Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
robertmaxton42
pushed a commit
to robertmaxton42/mathlib4
that referenced
this pull request
Sep 11, 2025
…nprover-community#25774) Most replacements that are also in leanprover-community#23676 have been copied over, but some have been optimised further. Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
joelriou
pushed a commit
to joelriou/mathlib4
that referenced
this pull request
Oct 2, 2025
…nprover-community#25774) Most replacements that are also in leanprover-community#23676 have been copied over, but some have been optimised further. Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most replacements that are also in #23676 have been copied over, but some have been optimised further.