Skip to content

[Merged by Bors] - feat(RingTheory/Ideal): prove transitivity for the relative norm#27152

Closed
xroblot wants to merge 20 commits intoleanprover-community:masterfrom
xroblot:relNorm_relNorm
Closed

[Merged by Bors] - feat(RingTheory/Ideal): prove transitivity for the relative norm#27152
xroblot wants to merge 20 commits intoleanprover-community:masterfrom
xroblot:relNorm_relNorm

Conversation

@xroblot
Copy link
Copy Markdown
Collaborator

@xroblot xroblot commented Jul 15, 2025

Let R ⊆ S ⊆ T be a tower of rings and I : Ideal T, then relNorm R I = relNorm R (relNorm S I)

Also, add the relNorm version of spanNorm_le_comap that was forgotten in a previous PR.


Open in Gitpod

@github-actions github-actions bot added large-import Automatically added label for PRs with a significant increase in transitive imports t-algebra Algebra (groups, rings, fields, etc) labels Jul 15, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 15, 2025

PR summary 0a6e2f47d0

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.IntegralClosure.IntegralRestrict 1916 1917 +1 (+0.05%)
Mathlib.RingTheory.Ideal.Norm.RelNorm 2000 2001 +1 (+0.05%)
Import changes for all files
Files Import difference
10 files Mathlib.NumberTheory.NumberField.Discriminant.Different Mathlib.NumberTheory.RamificationInertia.Galois Mathlib.RingTheory.DedekindDomain.Different Mathlib.RingTheory.Frobenius Mathlib.RingTheory.Ideal.Norm.RelNorm Mathlib.RingTheory.IntegralClosure.IntegralRestrict Mathlib.RingTheory.Invariant.Basic Mathlib.RingTheory.Invariant.Profinite Mathlib.RingTheory.Invariant Mathlib.RingTheory.Trace.Quotient
1

Declarations diff

+ Algebra.intNorm_intNorm
+ instance (B C : Type*) [CommRing B] [IsDomain B] [CommRing C] [IsDomain C] [Algebra A B]
+ le_spanNorm_spanNorm
+ relNorm_le_comap
+ relNorm_relNorm
+ spanNorm_spanNorm
+ spanNorm_spanNorm_of_bot_or_top

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 15, 2025
@riccardobrasca riccardobrasca self-assigned this Jul 15, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 15, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 15, 2025
@github-actions github-actions bot removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) large-import Automatically added label for PRs with a significant increase in transitive imports labels Jul 15, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 3, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 3, 2025
@grunweg grunweg added t-ring-theory Ring theory and removed t-algebra Algebra (groups, rings, fields, etc) labels Aug 4, 2025
@xroblot xroblot added the WIP Work in progress label Aug 15, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 16, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@xroblot xroblot removed the WIP Work in progress label Aug 17, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Aug 17, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 21, 2025
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 22, 2025

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 22, 2025
@kbuzzard
Copy link
Copy Markdown
Member

The lint error is an issue with simp says and it seems that an acceptable fix is to just replace the call with a simp only call and delete the says stuff.

@xroblot
Copy link
Copy Markdown
Collaborator Author

xroblot commented Aug 22, 2025

The lint error is an issue with simp says and it seems that an acceptable fix is to just replace the call with a simp only call and delete the says stuff.

There are in fact several calls to simp says that produce some errors. I am trying to collect them and fix them here: #28775

@xroblot
Copy link
Copy Markdown
Collaborator Author

xroblot commented Aug 22, 2025

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Aug 22, 2025
)

Let `R ⊆ S ⊆ T` be a tower of rings and `I : Ideal T`, then `relNorm R I = relNorm R (relNorm S I)`

Also, add the `relNorm` version of `spanNorm_le_comap` that was forgotten in a previous PR.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 22, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/Ideal): prove transitivity for the relative norm [Merged by Bors] - feat(RingTheory/Ideal): prove transitivity for the relative norm Aug 22, 2025
@mathlib-bors mathlib-bors bot closed this Aug 22, 2025
Paul-Lez pushed a commit to Paul-Lez/mathlib4 that referenced this pull request Aug 23, 2025
…nprover-community#27152)

Let `R ⊆ S ⊆ T` be a tower of rings and `I : Ideal T`, then `relNorm R I = relNorm R (relNorm S I)`

Also, add the `relNorm` version of `spanNorm_le_comap` that was forgotten in a previous PR.
pechersky pushed a commit to pechersky/mathlib4 that referenced this pull request Aug 25, 2025
…nprover-community#27152)

Let `R ⊆ S ⊆ T` be a tower of rings and `I : Ideal T`, then `relNorm R I = relNorm R (relNorm S I)`

Also, add the `relNorm` version of `spanNorm_le_comap` that was forgotten in a previous PR.
@xroblot xroblot deleted the relNorm_relNorm branch March 16, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants