[Merged by Bors] - refactor: rename Splits.splits_of_dvd to Splits.of_dvd#32815
Closed
tb65536 wants to merge 3 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - refactor: rename Splits.splits_of_dvd to Splits.of_dvd#32815tb65536 wants to merge 3 commits intoleanprover-community:masterfrom
Splits.splits_of_dvd to Splits.of_dvd#32815tb65536 wants to merge 3 commits intoleanprover-community:masterfrom
Conversation
tb65536
added
awaiting-CI
PR summary 1825e179b3Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
bot
removed
the
awaiting-CI
Ruben-VandeVelde
approved these changes
Dec 13, 2025
Contributor
Ruben-VandeVelde
left a comment
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
lgtm
maintainer delegate
|
|
||
| @[deprecated (since := "2025-11-25")] | ||
| alias splits_of_splits_of_dvd := Splits.splits_of_dvd | ||
| alias splits_of_of_dvd := Splits.of_dvd |
Contributor
Author
There was a problem hiding this comment.
Oops, good catch, thanks!
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
ghost
added
the
maintainer-merge
Member
|
Thanks! bors d+ |
Contributor
|
✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
delegated
tb65536
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 14, 2025
This PR renames `Splits.splits_of_dvd` to `Splits.of_dvd`, per this poll: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60Splits.2Eof_dvd.60.20vs.20.60Splits.2Esplits_of_dvd.60/near/560925458 Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Splits.splits_of_dvd to Splits.of_dvdSplits.splits_of_dvd to Splits.of_dvd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
Splits.splits_of_dvdtoSplits.of_dvd, per this poll: https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60Splits.2Eof_dvd.60.20vs.20.60Splits.2Esplits_of_dvd.60/near/560925458