Skip to content

[Merged by Bors] - feat(Data/ENat): add lemma ENat.iInf_eq_coe_iff#34144

Closed
IvanRenison wants to merge 9 commits intoleanprover-community:masterfrom
IvanRenison:ENat.iInf_eq_nat_iff
Closed

[Merged by Bors] - feat(Data/ENat): add lemma ENat.iInf_eq_coe_iff#34144
IvanRenison wants to merge 9 commits intoleanprover-community:masterfrom
IvanRenison:ENat.iInf_eq_nat_iff

Conversation

@IvanRenison
Copy link
Copy Markdown
Collaborator

@IvanRenison IvanRenison commented Jan 19, 2026

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Jan 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 19, 2026

PR summary 84a93e3a40

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ciInf_eq_iff
+ csInf_eq_iff
+ iInf_eq_coe_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@eric-wieser eric-wieser added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 19, 2026
@IvanRenison IvanRenison changed the title feat(Data/ENat): add lemma ENat.iInf_eq_nat_iff feat(Data/ENat): add lemma ENat.iInf_eq_coe_iff Jan 19, 2026
@IvanRenison IvanRenison removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 20, 2026
@robin-carlier robin-carlier added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 17, 2026
@IvanRenison IvanRenison removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 21, 2026
@mathlib-triage mathlib-triage bot assigned pechersky and unassigned TwoFX Mar 22, 2026
Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but can you also add the dual versions of the general versions (with sup instead of inf)?

@Vierkantor Vierkantor added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 26, 2026
@IvanRenison
Copy link
Copy Markdown
Collaborator Author

@Vierkantor do you know where exactly should I add the duals?

@Vierkantor Vierkantor removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 2, 2026
@Vierkantor
Copy link
Copy Markdown
Contributor

(Feel free to remove the awaiting-author label when you think you are done / are waiting for review feedback!)

I tried to dualize this myself, but it turns out argminOn doesn't have the argmaxOn counterpart, and so we'd need to redo the whole proof anyway. So this looks good to me for now, and later on @[to_dual] should automate the dualizing. In other words: this looks good to me.

I'm not sure if you had any other changes planned, and that's why you didn't remove the awaiting-author label yet. So:

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 2, 2026

✌️ IvanRenison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Apr 2, 2026
@IvanRenison
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 2, 2026
Co-authored-by: SnirBroshi <26556598+SnirBroshi@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 2, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/ENat): add lemma ENat.iInf_eq_coe_iff [Merged by Bors] - feat(Data/ENat): add lemma ENat.iInf_eq_coe_iff Apr 2, 2026
@mathlib-bors mathlib-bors bot closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants