[Merged by Bors] - chore: golf using grind#34423
Closed
euprunin wants to merge 6 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore: golf using grind#34423euprunin wants to merge 6 commits intoleanprover-community:masterfrom
grind#34423euprunin wants to merge 6 commits intoleanprover-community:masterfrom
Conversation
euprunin
changed the title
grind and add grind annotationgrind
PR summary 69cbc416b3Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
euprunin
changed the title
grindgrind and add grind annotation
Contributor
Author
|
!bench |
|
Benchmark results for 81f5e3a against 899a433 are in! @euprunin
No significant changes detected. |
Contributor
Author
|
!bench |
|
Benchmark results for f622b49 against 899a433 are in! @euprunin
Small changes (2✅, 18🟥)
|
Contributor
Author
|
!bench |
|
Benchmark results for f622b49 against 899a433 are in! @euprunin
Small changes (2✅, 18🟥)
|
Contributor
Author
|
!bench |
|
Benchmark results for 9b562ac against 899a433 are in! @euprunin
Small changes (1🟥)
|
Member
|
Please make sure when writing PR descriptions that you put it above the |
euprunin
changed the title
grind and add grind annotationgrind
Contributor
|
I am very confused by the radar results here, because the file modified in the PR rather has a +500M change, and I really don’t get how the change here can save -92G. Can you please merge master and re-bench? Other than that, the golf is reasonable IMO, though it does make the proof slightly less explicit. I have no strong opinion on this one and at this point one could grind it more aggressively, with something like |
robin-carlier
added
the
awaiting-author
Contributor
Author
|
!bench |
|
Benchmark results for ad33bd5 against 8cab065 are in! @euprunin
Small changes (2✅, 1🟥)
|
Contributor
Author
|
@robin-carlier Thanks for the review! Following your suggestion, I was able to golf the proof down to a single line (from 18 originally) and reduce the number of explicit lemma references to three (from 14). |
euprunin
removed
the
awaiting-author
artie2000
approved these changes
Mar 24, 2026
chenson2018
suggested changes
Mar 31, 2026
Contributor
chenson2018
left a comment
chenson2018
left a comment
There was a problem hiding this comment.
I think this makes some good changes, but left a review concerning maintainability.
Contributor
|
Thanks for the previous review! bors d=@chenson2018 |
Contributor
|
✌️ chenson2018 can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-triage
bot
added
the
delegated
chenson2018
approved these changes
Apr 2, 2026
Contributor
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
The goal of this golfing PR is to decrease the number of times lemmas are called explicitly (replacing calls to lemmas with calls to tactics). Any decrease in compilation time is a welcome side effect, although it is not a primary objective. Trace profiling results (shown if ≥10 ms before or after): * `LucasLehmer.norm_num_ext.sModNat_eq_sMod`: 950 ms before, 758 ms after 🎉 This golfing PR is batched under the following guidelines: * Up to ~5 changed files per PR * Up to ~25 changed declarations per PR * Up to ~100 changed lines per PR
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
grindgrind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this golfing PR is to decrease the number of times lemmas are called explicitly (replacing calls to lemmas with calls to tactics). Any decrease in compilation time is a welcome side effect, although it is not a primary objective.
Trace profiling results (shown if ≥10 ms before or after):
LucasLehmer.norm_num_ext.sModNat_eq_sMod: 950 ms before, 758 ms after 🎉This golfing PR is batched under the following guidelines: